Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.1 - Auto-restart, non-fatal file conversion errors #16

Open
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

shawnrushefsky
Copy link
Collaborator

@shawnrushefsky shawnrushefsky commented Jan 13, 2025

  • A new configuration option ALWAYS_RESTART_COMFYUI, which defaults to false. When true, the api will restart the comfyui service in the event that it exits. when false, the api server will itself exit when comfyui exits.
  • /health and /ready now have slightly different behaviors to accommodate the above. /health will always return 200 once the server is up and warm. /ready will return 503 during comfyui restarts.
  • In the event converting a file fails, the unconverted file will be returned. Previously, this would be a failed request.
  • Test cases: cogvideox and mochi
  • Begin work migrating to ghcr, scripts to build runtime and devel versions of the comfyui base image, and of the respective comfyui api images.
  • Workflow endpoints now support an asynchronous generateWorkflow export.
  • Webhooks of completed outputs now include a new field .event that will be output.complete. This opens the door for other events to be emitted via webhook, such as for failed generations, comfyui status, etc.

resolves #15

Copy link

🚀 Download the latest release candidate 🚀

@shawnrushefsky shawnrushefsky marked this pull request as ready for review January 13, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComfyUI dockerfile
3 participants