Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.0 - Comfy Events Via Webhook #20

Merged
merged 21 commits into from
Jan 21, 2025
Merged

1.8.0 - Comfy Events Via Webhook #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
aecb424
prompt.failed event
shawnrushefsky Jan 16, 2025
b580bc6
split out comfy utils
shawnrushefsky Jan 16, 2025
c56702c
configurable log levels
shawnrushefsky Jan 16, 2025
f579ce2
log websocket events
shawnrushefsky Jan 16, 2025
085e9da
update dependencies
shawnrushefsky Jan 16, 2025
9c26c69
wire up comfy events to emit webhooks
shawnrushefsky Jan 16, 2025
d226620
make sure to clear id map to avoid memory leak
shawnrushefsky Jan 16, 2025
fff1fc7
version bump
shawnrushefsky Jan 16, 2025
88b6cac
use websocket to wait for prompt completion
shawnrushefsky Jan 17, 2025
40ff878
document webhooks
shawnrushefsky Jan 17, 2025
70f083a
document new docker image home
shawnrushefsky Jan 17, 2025
74e0ede
markdown format
shawnrushefsky Jan 17, 2025
33302b0
update to comfy 0.3.12
shawnrushefsky Jan 17, 2025
17202d6
more detail in readme
shawnrushefsky Jan 17, 2025
694b07a
allow different endpoint names for webhook
shawnrushefsky Jan 17, 2025
8d61224
debug logging for events
shawnrushefsky Jan 17, 2025
af918ed
handle close events while waiting for image
shawnrushefsky Jan 17, 2025
f44314b
test new system event hooks
shawnrushefsky Jan 17, 2025
3c3e50a
remove unused imports
shawnrushefsky Jan 17, 2025
e40378d
document the "all" option for events
shawnrushefsky Jan 17, 2025
344de6d
remove unused imports. run system events test separately, different c…
shawnrushefsky Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
312 changes: 287 additions & 25 deletions README.md
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 6 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
comfyui:
image: ghcr.io/saladtechnologies/comfyui-api:comfy0.3.10-test-image
image: ghcr.io/saladtechnologies/comfyui-api:comfy0.3.12-test-image
volumes:
- ./bin:/app/bin
- ./test/docker-image/models:/opt/ComfyUI/models
Expand All @@ -9,10 +9,14 @@ services:
context: ./test/docker-image
dockerfile: Dockerfile
args:
- comfy_version=0.3.10
- comfy_version=0.3.12
ports:
- "3000:3000"
- "8188:8188"
# environment:
# ALWAYS_RESTART_COMFYUI: "true"
# SYSTEM_WEBHOOK_URL: "http://host.docker.internal:1234/system"
# SYSTEM_WEBHOOK_EVENTS: all
deploy:
resources:
reservations:
Expand Down
4 changes: 2 additions & 2 deletions docker/api.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ARG base=runtime
ARG comfy_version=0.3.10
ARG comfy_version=0.3.12
ARG pytorch_version=2.5.0
ARG cuda_version=12.1
FROM ghcr.io/saladtechnologies/comfyui-api:comfy${comfy_version}-torch${pytorch_version}-cuda${cuda_version}-${base}

ENV WORKFLOW_DIR=/workflows
ENV STARTUP_CHECK_MAX_TRIES=30

ARG api_version=1.7.2
ARG api_version=1.8.0
ADD https://github.com/SaladTechnologies/comfyui-api/releases/download/${api_version}/comfyui-api .
RUN chmod +x comfyui-api

Expand Down
2 changes: 1 addition & 1 deletion docker/build-api-images
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

usage="Usage: $0 [comfy_version] [torch_version] [cuda_version] [api_version]"

comfy_version=${1:-0.3.10}
comfy_version=${1:-0.3.12}
torch_version=${2:-2.5.0}
cuda_version=${3:-12.1}

Expand Down
2 changes: 1 addition & 1 deletion docker/build-comfy-base-images
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#! /usr/bin/bash

comfy_version=${1:-0.3.10}
comfy_version=${1:-0.3.12}
torch_version=${2:-2.5.0}
cuda_version=${3:-12.1}
bases=("runtime" "devel")
Expand Down
2 changes: 1 addition & 1 deletion docker/comfyui.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN apt-get update && apt-get install -y \
RUN pip install --upgrade pip
RUN pip install comfy-cli
WORKDIR /opt
ARG comfy_version=0.3.10
ARG comfy_version=0.3.12
RUN git clone --depth 1 --branch v${comfy_version} https://github.com/comfyanonymous/ComfyUI.git
WORKDIR /opt/ComfyUI
RUN pip install torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/cu121
Expand Down
2 changes: 1 addition & 1 deletion docker/push-api-images
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

usage="Usage: $0 [comfy_version] [torch_version] [cuda_version] [api_version]"

comfy_version=${1:-0.3.10}
comfy_version=${1:-0.3.12}
torch_version=${2:-2.5.0}
cuda_version=${3:-12.1}

Expand Down
2 changes: 1 addition & 1 deletion docker/push-comfy-base-images
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

usage="Usage: $0 [comfy_version] [torch_version] [cuda_version]"

comfy_version=${1:-0.3.10}
comfy_version=${1:-0.3.12}
torch_version=${2:-2.5.0}
cuda_version=${3:-12.1}

Expand Down
Loading
Loading