Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-17458039 - Handle error states for social/passwordless login and reset password #2185

Open
wants to merge 14 commits into
base: feature-passwordless-social-login
Choose a base branch
from

Conversation

yunakim714
Copy link
Collaborator

@yunakim714 yunakim714 commented Jan 6, 2025

Description

Before releasing social and passwordless login, we need to ensure that all error states are covered and presented in the UI.
The following spreadsheet details different error scenarios for social and passwordless login, and what error message is prompted after the error: Social/Passwordless Login Error States

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Add error handling for the different possible scenarios detailed in the above spreadsheet

How to Test-Drive This PR

  • Manually step through each scenario in the spreadsheet and verify that you can see the correct error message

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@yunakim714 yunakim714 marked this pull request as ready for review January 7, 2025 15:54
@yunakim714 yunakim714 requested a review from a team as a code owner January 7, 2025 15:54
@yunakim714 yunakim714 requested a review from hajinsuha1 January 7, 2025 15:54
@hajinsuha1
Copy link
Collaborator

@yunakim714 It seems like users aren't able to resubmit for passwordless login after they cause an error.

Steps to reproduce:

  1. Open the auth modal/login page
  2. Enter a non existent user's email like a@a
  3. Click Continue Securely
  4. Enter an existent user's email like [email protected]

Expected:

  • /passwordless/login API call is made and check email page is displayed

Actual:

  • /passwordless/login API call is not made and login page is still displayed

@yunakim714
Copy link
Collaborator Author

@hajinsuha1 Resolved the bug! Let me know if you still see the issue. Thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants