Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade packages in yarn #1966

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

upgrade packages in yarn #1966

wants to merge 9 commits into from

Conversation

xinnanlisf
Copy link
Contributor

Critical Changes

Changes

Issues Closed

New Metadata

Unpackaged Metadata

Deleted Metadata

Testing Notes

MatthewBlanski
MatthewBlanski previously approved these changes Mar 29, 2022
View reviewed changes
@MatthewBlanski MatthewBlanski requested review from davidmreed, a team, davidjray and jofsky and removed request for davidmreed, a team and davidjray March 29, 2022 18:36
@github-actions
Copy link

Hi 👋 @xinnanlisf! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

@MatthewBlanski MatthewBlanski requested review from a team and removed request for jofsky March 29, 2022 18:39
@github-actions
Copy link

This PR has been labeled as ready for Release Engineering review by
@MatthewBlanski.

davidmreed
davidmreed previously approved these changes Mar 30, 2022
View reviewed changes
@xinnanlisf xinnanlisf dismissed stale reviews from davidmreed and MatthewBlanski via a7fe351 April 1, 2022 14:10
@xinnanlisf xinnanlisf mentioned this pull request Apr 1, 2022
Closed
@davidmreed davidmreed mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmreed davidmreed davidmreed approved these changes

@MatthewBlanski MatthewBlanski Awaiting requested review from MatthewBlanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinnanlisf @davidmreed @MatthewBlanski