Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes generation to use static text #1986

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

jcschultz
Copy link
Contributor

Auto generated release notes should now use static text linking to the H&T SFDO release notes. This change updates how the release notes are generated for each production release to instead use that static text.

See: TD-0127818

Critical Changes

Changes

Issues Closed

W-12659914

New Metadata

Unpackaged Metadata

Deleted Metadata

Testing Notes

Auto generated release notes should now use static text linking to the H&T SFDO release notes. This change updates how the release notes are generated for each production release to instead use that static text.

See: https://gus.lightning.force.com/lightning/r/ADM_Team_Dependency__c/a0nEE0000008Y2vYAE/view
Signed-off-by: jcschultz <[email protected]>
@jcschultz jcschultz requested a review from a team as a code owner March 15, 2023 16:52
@jcschultz jcschultz requested a review from jstvz March 15, 2023 16:52
@github-actions
Copy link

Hi 👋 @jcschultz! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

aarsvoboda
aarsvoboda previously approved these changes Mar 15, 2023
Copy link

@aarsvoboda aarsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions
Copy link

This PR has been labeled as ready for Release Engineering review by
@jcschultz. Reviews have been requested from: @jstvz.

Copy link
Member

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

±: Since the option was just added we need to update the minimum_cumulusci_version to 3.74.0.

This will break your builds until we get MetaCI updated, however.

@jcschultz
Copy link
Contributor Author

@jstvz When will MetaCI be updated to 3.74?

@jstvz
Copy link
Member

jstvz commented Mar 16, 2023

@jstvz When will MetaCI be updated to 3.74?

Next day or so. (SFDO-Tooling/MetaCI#2843)

Bumping up the minimum cci version to 3.74.0 to generate static release notes.

Signed-off-by: jcschultz <[email protected]>
@jcschultz
Copy link
Contributor Author

@jstvz , I see MetaCI has been updated. And I've updated the min cci version to 3.74.0. This is ready for your re-review. Thanks!

@jcschultz jcschultz merged commit e8efcfe into main Mar 20, 2023
@jcschultz jcschultz deleted the feature/jschultz/staticReleaseNote branch March 20, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants