Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] HistoryViewController -> PostViewController 뷰 전환 기능 추가 #76

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[Feature] HistoryViewController -> PostViewController 뷰 전환 기능 추가 #76

wants to merge 4 commits into from

Conversation

JUNY0110
Copy link
Collaborator

@JUNY0110 JUNY0110 commented May 2, 2023 •
edited
Loading

Motivation 🥳 (코드를 추가/변경하게 된 이유)

  • HistoryViewController에서 PostViewController로 뷰 전환하기 위함.

Key Changes 🔥 (주요 구현/변경 사항)

  • HistoryCoordinator 삭제
  • HistoryViewController delegate를 SegmentViewController로 설정
  • SegmentCoordinator에 pushToPostViewController() 함수 추가

ToDo 📆 (남은 작업)

  • 데이터 연동하여 기본 뷰가 아닌, 정확한 데이터가 전달되도록 하는 것

ScreenShot 📷 (참고 사진)

Simulator Screen Recording - iPhone 14 Pro - 2023-05-03 at 00 59 52

To Reviewers 🙏 (리뷰어에게 전달하고 싶은 말)

  • 간단한 코드입니다. 가볍게 확인해주세요.

Reference 🔗

  • 없음.

Close Issues 🔒 (닫을 Issue)

Close #75.

@JUNY0110 JUNY0110 added the feature 새로운 기능 추가 label May 2, 2023
@JUNY0110 JUNY0110 self-assigned this May 2, 2023
@JUNY0110 JUNY0110 requested a review from taek0622 as a code owner May 2, 2023 16:01
@JUNY0110 JUNY0110 linked an issue May 2, 2023 that may be closed by this pull request
[Feature] HistoryViewController의 게시물 클릭 시 뷰 전환(Coordinator) #75
Open
@JUNY0110 JUNY0110 requested a review from creohwan as a code owner May 2, 2023 16:01
taek0622
taek0622 approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@taek0622 taek0622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생각보다 작업이 빠르게 끝났네요.
고생하셨습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taek0622 taek0622 taek0622 approved these changes

@creohwan creohwan Awaiting requested review from creohwan creohwan is a code owner

Assignees

@JUNY0110 JUNY0110

Labels
feature 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] HistoryViewController의 게시물 클릭 시 뷰 전환(Coordinator)
2 participants
@JUNY0110 @taek0622