Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and ML retrain #575

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Refactoring and ML retrain #575

merged 7 commits into from
Jul 8, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jun 30, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Enchance value sanitizer - cut-off url like variable-values
  • skip extra check for None in value - moved to scanner
  • migration to python3.10 for benchmark
  • early stopping callback for ML train
  • variable positions produced in report for easy review with colored text
  • simplify many filters to use ML cut-off. otherwise, ML cannot be learned.

20240701_133141

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek changed the title Ml Refactoring and ML retrain Jul 1, 2024
@babenek babenek marked this pull request as ready for review July 1, 2024 13:53
@babenek babenek requested a review from a team as a code owner July 1, 2024 13:53
babenek
babenek commented Jul 2, 2024
View reviewed changes
credsweeper/rules/config.yaml Outdated Show resolved Hide resolved
babenek
babenek commented Jul 2, 2024
View reviewed changes
credsweeper/rules/config.yaml Outdated Show resolved Hide resolved
@babenek
Copy link
Contributor Author

babenek commented Jul 3, 2024

@Samsung/credsweeper_maintainers please review the PR

@babenek babenek mentioned this pull request Jul 5, 2024
Merged
2 tasks
xDizzix
xDizzix approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babenek babenek merged commit 31dcd1d into Samsung:main Jul 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yullia Yullia Yullia approved these changes

@xDizzix xDizzix xDizzix approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @xDizzix @Yullia