Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters, value sanitizer improvements #585

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jul 16, 2024

Description

Please include a summary of the change and which is fixed.

  • FilePathFileter improvement for unix suggestion path
  • Atlassian tokens applied common CRC32 validation
  • Value and variable sanitizer improvement for escaped whitespaces

How has this been tested?

Please describe the tests that you ran to verify your changes.

@babenek babenek requested a review from a team as a code owner July 16, 2024 10:03
@babenek babenek marked this pull request as draft July 16, 2024 10:18
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.34%. Comparing base (9acea8b) to head (c8e6790).
Report is 1 commits behind head on main.

Files Patch % Lines
credsweeper/credentials/line_data.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   90.23%   90.34%   +0.10%     
==========================================
  Files         131      131              
  Lines        4680     4701      +21     
  Branches      755      761       +6     
==========================================
+ Hits         4223     4247      +24     
+ Misses        304      301       -3     
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review July 16, 2024 12:19
Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@babenek babenek merged commit 16dd8ac into Samsung:main Jul 16, 2024
27 checks passed
@babenek babenek deleted the valsanitizer branch July 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants