Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving for binary file detection for latin1 #589

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Aug 1, 2024

Description

Please include a summary of the change and which is fixed.

  • Detect unprintable bytes during LATIN-1 decoding

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review August 1, 2024 12:18
@babenek babenek requested a review from a team as a code owner August 1, 2024 12:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.35%. Comparing base (dcf0a75) to head (5d94cce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
+ Coverage   90.34%   90.35%   +0.01%     
==========================================
  Files         131      131              
  Lines        4713     4718       +5     
  Branches      762      764       +2     
==========================================
+ Hits         4258     4263       +5     
  Misses        302      302              
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babenek babenek requested review from Yullia, csh519, kmnls and iuriimet August 1, 2024 13:27
@babenek babenek merged commit 5f05701 into Samsung:main Aug 1, 2024
27 checks passed
@babenek babenek deleted the bindetect branch August 1, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants