Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed IPv4 and IPv6 patterns #591

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Removed IPv4 and IPv6 patterns #591

merged 1 commit into from
Aug 6, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Aug 1, 2024

Description

Please include a summary of the change and which is fixed.

  • Removed IPv4 and IPv6 patterns

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review August 6, 2024 09:19
@babenek babenek requested a review from a team as a code owner August 6, 2024 09:19
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPs will be removed from rule due to they are PII.

LGTM 👍

@babenek babenek merged commit 9cc0d58 into Samsung:main Aug 6, 2024
27 checks passed
@babenek babenek deleted the noip branch August 6, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants