Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huggingface and Groq patterns #609

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Huggingface and Groq patterns #609

merged 4 commits into from
Sep 30, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Sep 27, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add Groq API Key and Hugging Face User Access Token patterns
  • Reorganize ranges in rules patern for common style 0-9A-Za-z (ASCII order)
  • remove negative patterns for borders of base64urls-safe patterns. e.g. / - may right after token in URL

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review September 27, 2024 08:01
@babenek babenek requested a review from a team as a code owner September 27, 2024 08:01
Yullia
Yullia approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 20c72e1 into Samsung:main Sep 30, 2024
27 checks passed
@babenek babenek deleted the newpatterns branch September 30, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yullia Yullia Yullia approved these changes

@xDizzix xDizzix xDizzix approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @xDizzix @Yullia