Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashicorp Vault Token #625

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Hashicorp Vault Token #625

merged 4 commits into from
Dec 3, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 2, 2024

Description

Please include a summary of the change and which is fixed.

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review December 3, 2024 07:05
@babenek babenek requested a review from a team as a code owner December 3, 2024 07:05
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my think, new rule can be added whether the token has short expiring time(24h).
We don't know the token already expired or not, so we should detect them and we can mark them as high severity in my think.

So I agree to adding those new rules.
LGTM 👍

Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@babenek babenek merged commit 480eb7c into Samsung:main Dec 3, 2024
32 checks passed
@babenek babenek deleted the hashicorp branch December 3, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants