Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some FP cases for base64 parts #627

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Fix some FP cases for base64 parts #627

merged 4 commits into from
Dec 5, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 4, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek requested a review from a team as a code owner December 4, 2024 14:01
Yullia
Yullia previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appoved

@babenek babenek requested a review from Yullia December 5, 2024 08:36
csh519
csh519 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add + to comparing the line and checks 3-digits in value.

LGTM 👍

Yullia
Yullia approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit caf6bd6 into Samsung:main Dec 5, 2024
32 checks passed
@babenek babenek deleted the fpfix branch December 5, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csh519 csh519 csh519 approved these changes

@Yullia Yullia Yullia approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@iuriimet iuriimet Awaiting requested review from iuriimet

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @Yullia @csh519