Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update value_discord_bot_check.py #634

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update value_discord_bot_check.py #634

merged 1 commit into from
Dec 12, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Dec 12, 2024

Description

Please include a summary of the change and which is fixed.

  • Fix wrong entropy part

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.37%. Comparing base (e5a4ee8) to head (211d984).

Files with missing lines Patch % Lines
credsweeper/filters/value_discord_bot_check.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   91.35%   91.37%   +0.01%     
==========================================
  Files         146      146              
  Lines        5032     5032              
  Branches      777      777              
==========================================
+ Hits         4597     4598       +1     
  Misses        286      286              
+ Partials      149      148       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review December 12, 2024 10:53
@babenek babenek requested a review from a team as a code owner December 12, 2024 10:53
@Yullia Yullia self-requested a review December 12, 2024 10:56
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@babenek babenek merged commit 59f6e71 into main Dec 12, 2024
34 checks passed
@babenek babenek deleted the babenek-patch-2 branch December 12, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants