Transform and state sorting reform #1827

NolaDonato · 2018-04-10T02:30:14Z

Added capability to calculate matrices in a general way and put them in a transform blocfk
Accumulated state sorting culling and transform code into a new RenderSorter class
Custom state sorting for main scene, post effects and shadow maps
Eliminated redundant GL state calls
Accumulated all render state into a single 64 bit number
Store render state in render pass
Added transparent flag to ShaderData
Added GVRRenderer class

GearVRF DCO signed off by: Nola Donato [email protected]

Not for merge yet - Vulkan is not working.

t Please enter the commit message for your changes. Lines starting

liaxim · 2018-04-10T13:52:01Z

There are some commits adding pictures that do not belong here.

roshanch · 2018-04-10T20:56:13Z

GVRf/Framework/framework/src/main/jni/objects/components/render_data.cpp

        render_data_string.append(std::to_string(mesh_->getVertexBuffer()->getDescriptor()));
        hash_code = render_data_string;
-        hash_code_dirty_ = false;
+        pass(0)->render_modes().clearDirty();


not for all the passes?

We have to talk about the hash code. All of the render states now fit in a single 64 bit word, one for each pass. The render passes are rendered separately, not together anymore. OpenGL doesn't use this hash code. We should discuss its significance in Vulkan.

Caprica666 · 2018-04-11T00:05:58Z

I removed the one picture that was left in the repo. How do I remove commits in the middle? I was in a hurry to finish Siggraph registration and they needed photos of a specific size for the badge. I used Git to transfer stuff between PC and Linux...

liaxim · 2018-04-11T14:31:38Z

You could "git revert" the unwanted commits. Or use git interactive rebase - "git rebase -i HEAD~15" to drop those commits.

liaxim · 2018-04-11T15:11:51Z

And needs a rebase

liaxim · 2018-04-11T15:14:45Z

GVRf/Framework/framework/src/main/jni/engine/renderer/render_state.h

+            offset_factor = src.offset_factor;
+            offset_units = src.offset_units;
+            render_order = src.render_order;
+            sample_coverage = src.sample_coverage;


Missing return; please compile with GVRF_USE_CLANG=true and address the warnings in the new and changed code.

liaxim · 2018-04-11T15:26:22Z

gvr-accessibility doesn't look right:

liaxim · 2018-04-11T15:27:23Z

gvr-controls:

liaxim · 2018-04-11T15:28:53Z

gvr-immersivepedia

liaxim · 2018-04-11T15:29:54Z

gvr-keyboard launches into a black screen

liaxim · 2018-04-11T15:30:44Z

gvr-multilight - z-fighting?

liaxim · 2018-04-11T15:31:58Z

gvr-modelviewer2 - looks weird, giant reticle

liaxim · 2018-04-11T15:33:33Z

gvr-shadows doesn't look right as you look up and down

liaxim · 2018-04-11T15:34:34Z

gvr-sceneobjects

liaxim · 2018-04-11T15:36:30Z

gvr-simplephysics, gvr-switch, gvr-tutorial-lesson6, gvr-x3d-demo all don't work

liaxim · 2018-04-11T15:40:04Z

Such a giant change needs to be backed up by automated tests proving correctness; or at least some level of. The previous thing was quite thoroughly tested over an extended period of time; I seriously doubt going through all the demo covers everything and can be considered enough for a change of this magnitude.

liaxim · 2018-04-11T16:41:29Z

Ok, is there a Demos pull request that goes along with this one that is missing?

liaxim · 2018-04-11T17:03:45Z

GVRf/Framework/framework/src/main/java/org/gearvrf/shaders/GVRPhongLayeredShader.java

+     * @param isStereo       true for stereo rendering, false for mono
+     * @returns number of matrices actually calculated and stored in the output buffer
+     */
+    public static int calcMatrix(float[] inputMatrices, float[] outputMatrices, int numMatrices, boolean isStereo)


The calcMatrix methods on the Java side show up as unused. Are they needed?

NolaDonato · 2018-04-11T20:27:36Z

PR #597 in GearVRf-Demos addresses some of these issues. I am debugging the others. I think there is an issue with render mask which is why gvr-sceneobjects is broken. I also took out the default of making everything use alpha blending. This is why some of the others are broken. We should not have this on by default.

liaxim · 2018-04-11T23:17:07Z

GVRf/Extensions/gvrf-particlesystem/src/main/res/raw/particle_vert.vsh

-       	    gl_Position =  u_mvp * posn;
-    #endif
-
+    gl_Position =  u_mvp * posn;


The HAS_MULTIVIEW ifdef block is really not needed anymore?

No, this is no longer necessary because the Java shader generation code takes care of it now.

NolaDonato · 2018-04-12T01:59:48Z

There were some shader generation bugs causing some issues with the examples. I have fixed these. Now the immersivepedia, accessibility, shadows, controls, simplephysics, modelviewer2, keyboard, switch, tutorial , and x3ddemo samples work now.

liaxim · 2018-05-30T18:33:30Z

It is unfortunate that this work cannot be done in more incremental way.

roshanch · 2018-05-30T18:46:48Z

the reason I am saying it because efforts needed to rebase it. everyday we have to rebase it..

liaxim · 2018-05-30T18:54:02Z

@roshanch I absolutely agree. This is why this work needs to be broken down and done in increments. Also this pull is of such size that it is effectively un-reviewable. Increments we can reason about and easier to test since you can tell what to target.

NolaDonato · 2018-05-30T18:54:07Z

I just did the rebase. Since you have been doing it every day perhaps you can spot what I did wrong. Sushant and I are going to try to do the Vulkan part.

verify all shaders have the same offsets

NolaDonato · 2018-06-01T20:10:10Z

I have done a lot of testing and the problem is not a merge failure. The code works fine on a Note8 with Android O. It fails on a Note8 with Android N. It also fails on an S8 with Android O. It appears to corrupt uniform blocks. The lighting anomalies are caused by the view matrix being incorrect. Printing it right before the uniform block is loaded into the GPU shows no errors. Still investigating.

sushantojal · 2018-06-04T19:21:33Z

The issue is with the GL_MAX_VERTEX_UNIFORM_COMPONENTS query. Looks like the value returned by the driver is not reliable. For gvr-multilight, any block of more than 18 matrices (288 floats) does not work for the S8+ (adreno, Android N) I am using; even though the query returns 1024 (64 mats). Works fine for values 18 and below.
Similar issues have existed for other drivers, but I wasnt able to find any documentation confirming if this is a known issue on this particular driver version.
We'll need to come up with a reliable workaround for this.

Fixed faulty C++ logic for notifying components when they are removed / added from scene Delete light block when light list is cleared (from rendering thread) This fixes intermittent failures with SIDIA lighting tests

Fixes crash in normal mapping test

1. Fix X3D and PBR shader bindings to be consistent 2. Fix X3D normal generation 3. Fix X3D shader texcoords

…esort

…tatesort

…esort

…nto statesort" This reverts commit 4258e7d, reversing changes made to 2602799.

liaxim · 2018-11-28T20:46:03Z

Should we close?

NolaDonato · 2018-11-29T19:59:29Z

No I am going to revive this one

liaxim · 2018-11-29T20:08:37Z

Revive against GearVRf instead of SXRSDK?!

NolaDonato · 2018-11-29T22:24:24Z

That is easier to get working I think. Once it works with GearVRf I can rename it and do a PR against SXR.

NolaDonato added 7 commits March 21, 2018 14:41

adding picture to transfer to linux

f03b711

Merge branch 'master' of https://github.com/NolaDonato/GearVRf

7b0759e

wider head photo

6333b7c

vertical head shot

b001c8f

t Please enter the commit message for your changes. Lines starting

Merge branch 'master' of https://github.com/Samsung/GearVRf

4f80b0f

Merge branch 'master' of github.com:Samsung/GearVRf

32d5f60

Merge branch 'master' of github.com:Samsung/GearVRf

5a36c72

liaxim added the ready for review label Apr 10, 2018

roshanch reviewed Apr 10, 2018

View reviewed changes

liaxim reviewed Apr 11, 2018

View reviewed changes

liaxim added the work in progress label Apr 12, 2018

NolaDonato added 3 commits May 30, 2018 13:25

fix merge issue with PBR shader

06c626d

fix matrix expression calculator

5502b71

verify all shaders have the same offsets

remove redundant render call

201cb09

Merge branch 'master' of github.com:Samsung/GearVRf into statesort

c63542b

NolaDonato added 16 commits June 5, 2018 17:13

merge with master

347496e

spell lightmapTexture consistently

f5ed41b

fix in PBR and X3D shaders

4652793

Fix bugs with adding / removing lights

ff69744

Fixed faulty C++ logic for notifying components when they are removed / added from scene Delete light block when light list is cleared (from rendering thread) This fixes intermittent failures with SIDIA lighting tests

Fix vertex buffer copy constructor, add missing normal coord

610c150

Fixes crash in normal mapping test

Merge with master

cc276ce

1. Fix X3D and PBR shader bindings to be consistent 2. Fix X3D normal generation 3. Fix X3D shader texcoords

merge with PR Samsung#1899

aafffe2

fix for adding and removing lights

bf18120

fix X3D load without animations

e9019c0

comment out log message

87f5a3d

Merge branch 'master' of https://github.com/Samsung/GearVRf into stat…

a767d4d

…esort

fix pbr shader binding conflict

7e44840

fix pbr shader compile issue

75c0f73

Merge branch 'master' of https://github.com/NolaDonato/GearVRf into s…

2602799

…tatesort

Merge branch 'master' of https://github.com/Samsung/GearVRf into stat…

4258e7d

…esort

Revert "Merge branch 'master' of https://github.com/Samsung/GearVRf i…

5e296c4

…nto statesort" This reverts commit 4258e7d, reversing changes made to 2602799.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transform and state sorting reform #1827

Transform and state sorting reform #1827

NolaDonato commented Apr 10, 2018

liaxim commented Apr 10, 2018

roshanch Apr 10, 2018

Caprica666 Apr 11, 2018

Caprica666 commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim Apr 11, 2018

NolaDonato commented Apr 11, 2018

liaxim Apr 11, 2018

NolaDonato Apr 12, 2018

NolaDonato commented Apr 12, 2018

liaxim commented May 30, 2018

roshanch commented May 30, 2018

liaxim commented May 30, 2018

NolaDonato commented May 30, 2018

NolaDonato commented Jun 1, 2018

sushantojal commented Jun 4, 2018

liaxim commented Nov 28, 2018

NolaDonato commented Nov 29, 2018

liaxim commented Nov 29, 2018

NolaDonato commented Nov 29, 2018

Transform and state sorting reform #1827

Are you sure you want to change the base?

Transform and state sorting reform #1827

Conversation

NolaDonato commented Apr 10, 2018

liaxim commented Apr 10, 2018

roshanch Apr 10, 2018

Choose a reason for hiding this comment

Caprica666 Apr 11, 2018

Choose a reason for hiding this comment

Caprica666 commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim Apr 11, 2018

Choose a reason for hiding this comment

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim commented Apr 11, 2018

liaxim Apr 11, 2018

Choose a reason for hiding this comment

NolaDonato commented Apr 11, 2018

liaxim Apr 11, 2018

Choose a reason for hiding this comment

NolaDonato Apr 12, 2018

Choose a reason for hiding this comment

NolaDonato commented Apr 12, 2018

liaxim commented May 30, 2018

roshanch commented May 30, 2018

liaxim commented May 30, 2018

NolaDonato commented May 30, 2018

NolaDonato commented Jun 1, 2018

sushantojal commented Jun 4, 2018

liaxim commented Nov 28, 2018

NolaDonato commented Nov 29, 2018

liaxim commented Nov 29, 2018

NolaDonato commented Nov 29, 2018