-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Rebase DevelNUI #6326
Merged
Merged
[NUI] Rebase DevelNUI #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since those usecase break some logic, let we decide to deprecate the componentewise logic. Instead just create new property index - like COLOR_RED, SIZE_HEIGHT. Signed-off-by: Eunki, Hong <[email protected]>
* [NUI] Add multi-mimetype feature for Drag and Drop Contents - Allow to set multi-mimetypes for source client (use DragInfo) - Target client receive source's mimetypes from source client when Enter, Move, Leave - Target client can set mimetype to receive - Refactoring code for readability - Refactoring codes for readability * Refactoring data structure and duplicated codes * Apply clean code for Drag and Drop
Signed-off-by: Bowon Ryu <[email protected]>
taehyub
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
jaehyun0cho,
everLEEst,
rabbitfor,
hinohie and
wonrst
as code owners
September 11, 2024 11:15
jaehyun0cho
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tscholb
approved these changes
Sep 11, 2024
Internal API ChangedAdded: 4, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.DragAndDrop/DragAndDropEventHandler)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.DragAndDrop::AddListener(Tizen.NUI.Window,System.String,Tizen.NUI.DragAndDrop/DragAndDropWindowEventHandler)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Collections.Generic.Dictionary`2<System.String,System.String> Tizen.NUI.DragData::DataMap
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String[] Tizen.NUI.DragEvent::MimeTypes()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NUI] Rebase DevelNUI