Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Add value type: control state #6546

Open
wants to merge 1 commit into
base: DevelNUI
Choose a base branch
from
Open

[NUI] Add value type: control state #6546

wants to merge 1 commit into from

Conversation

rabbitfor
Copy link
Collaborator

@rabbitfor rabbitfor commented Jan 6, 2025 •
edited
Loading

Description of Change

Introduce the value type of ControlState. It replaces ControlState implementation.

API Changes

  • ACR:

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 23, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.BaseComponents.LControlState

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::All

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Disabled

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::DisabledFocused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::DisabledSelected

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Focused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Normal

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Other

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Pressed

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Selected

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::SelectedFocused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::SelectedPressed

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Contains(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Equals(System.Object)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Equals(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::HasIntersectionWith(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.BaseComponents.LControlState::op_Equality(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.BaseComponents.LControlState::op_Inequality(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.NUI.BaseComponents.LControlState::GetHashCode()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String Tizen.NUI.BaseComponents.LControlState::ToString()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Create(System.String)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::op_Addition(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::op_Subtraction(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

everLEEst
everLEEst reviewed Jan 7, 2025
View reviewed changes
src/Tizen.NUI/src/devel/LControlState.cs Outdated
/// Defines a value type of control state.
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public readonly struct LControlState
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed on offline,
It is slightly different with other L-Struct so I think it could be renamed something else. ControlState has this struct(has-a), so State, or StateValue could be the option.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the updated code. Thank you :)

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 23, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.BaseComponents.LControlState

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::All

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Disabled

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::DisabledFocused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::DisabledSelected

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Focused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Normal

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Other

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Pressed

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Selected

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::SelectedFocused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::SelectedPressed

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Contains(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Equals(System.Object)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Equals(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::HasIntersectionWith(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.BaseComponents.LControlState::op_Equality(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.BaseComponents.LControlState::op_Inequality(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.NUI.BaseComponents.LControlState::GetHashCode()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String Tizen.NUI.BaseComponents.LControlState::ToString()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Create(System.String)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::op_Addition(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::op_Subtraction(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

@rabbitfor
[NUI] Add value type: control state
71eb54f 
Introduce the value type of ControlState. It replaces ControlState implementation.

Signed-off-by: Jiyun Yang <[email protected]>
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 23, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.BaseComponents.LControlState

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::All

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Disabled

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::DisabledFocused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::DisabledSelected

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Focused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Normal

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Other

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Pressed

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Selected

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::SelectedFocused

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::SelectedPressed

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Contains(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Equals(System.Object)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::Equals(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.LControlState::HasIntersectionWith(Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.BaseComponents.LControlState::op_Equality(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.BaseComponents.LControlState::op_Inequality(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.NUI.BaseComponents.LControlState::GetHashCode()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.String Tizen.NUI.BaseComponents.LControlState::ToString()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::Create(System.String)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::op_Addition(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.BaseComponents.LControlState Tizen.NUI.BaseComponents.LControlState::op_Subtraction(Tizen.NUI.BaseComponents.LControlState,Tizen.NUI.BaseComponents.LControlState)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everLEEst everLEEst everLEEst left review comments

@hyunjushin hyunjushin Awaiting requested review from hyunjushin hyunjushin is a code owner

@dongsug-song dongsug-song Awaiting requested review from dongsug-song dongsug-song is a code owner

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

@hinohie hinohie Awaiting requested review from hinohie hinohie is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Devel-NUI Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabbitfor @TizenAPI-Bot @everLEEst