-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Add FullScreenMode to InputMethodContext #6593
Open
wonrst
wants to merge
42
commits into
Samsung:DevelNUI
Choose a base branch
from
wonrst:DevelNUI_imfcontext_fullscreen
base: DevelNUI
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103,668
−6,162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback Let we keep Idler callback list as membery of internal Application class, and allow to remove them during idler callback execute. Signed-off-by: Eunki, Hong <[email protected]>
…ImageUrl Since ImageUrl's reference should be hold on image visual, we should generate image visual synchronously, not on Processor time. + Minor code clean up applied Signed-off-by: Eunki, Hong <[email protected]>
Signed-off-by: Changgyu Choi <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
* Do not convert Vector4 to Color when initializing static colors * Eventually, static colors should be created by r, g, b values by c# code, not getting from DALi * Preload static colors Signed-off-by: Jiyun Yang <[email protected]>
ControlState was implemented inefficently on the memory and the performance. This patch purposed to reduce inefficency by using bitflags on the state instead of string list. [https://github.sec.samsung.net/NUI/OneUIComponents/issues/15] long type bitmask will be represent each states, 1 1 1 1 1 O S D P F Normal : 0L Focused : 1L Pressed : 2L Disabled : 4L Selected : 8L Other : 16L and All : 31L This concept is based on VisualState of NUI2, https://github.sec.samsung.net/dotnet/nui2/blob/main/src/Tizen.NUI2.Components/Base/ViewState.cs but we had to modified few states to keep backward compatibility of NUI ControlState.
Reorganized entire project structure for improved clarity and maintainability. Introduced customizable interfaces for AI functionalities, allowing seamless integration of third-party modules. Optimized existing code base for increased efficiency and reduced redundancy. Co-authored-by: Angler <[email protected]>
Since transform data is kind of renderer property internally, we don't need to re-create them. Let we use UpdateProperty action for this case. Signed-off-by: Eunki, Hong <[email protected]>
- We MUST call ReleaseBuffer after call AcquireBuffer - We MUST call AcquireBUffer before call ReleaseBuffer If not, exception or deadlock will occured. Signed-off-by: Eunki, Hong <[email protected]>
Co-authored-by: Woochan Lee <[email protected]>
…tidl (Samsung#6536) * Add new methods to support new types in tidl Signed-off-by: pjh9216 <[email protected]> * Add attributes for internal APIs Signed-off-by: pjh9216 <[email protected]> * Use sizeof operator Signed-off-by: pjh9216 <[email protected]> --------- Signed-off-by: pjh9216 <[email protected]>
Introduce the value type of color, vector2 and shadow. They will replace existing reference types gradually. Signed-off-by: Jiyun Yang <[email protected]>
NUI Language version upgrade for 9.
Let we add 'using' mark for temerally used `PropertyValue`. Optimize PropertyMap.Add() API if it is prepared. It is knd of next-step. So current PR could be keep going on Signed-off-by: Eunki, Hong <[email protected]>
PivotPoint, AnchorPoint, Position
Signed-off-by: Jiyun Yang <[email protected]>
This also includes PropertyMap optimizations to prevent value type being conveted to reference type again. Signed-off-by: Jiyun Yang <[email protected]>
(1) Introduce the value type of ControlState. It replaces ControlState implementation. (2) Notify IsEnabled changed to control state outside of view. Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Seungho Baek <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Eunki, Hong <[email protected]>
Signed-off-by: Junseok Kim <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
Signed-off-by: Jiyun Yang <[email protected]>
To support full screen mode of the input panal. Signed-off-by: Bowon Ryu <[email protected]>
wonrst
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst,
rabbitfor and
hinohie
as code owners
January 21, 2025 01:45
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.InputMethodContext::FullScreenMode()
|
hinohie
approved these changes
Jan 21, 2025
everLEEst
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
rabbitfor
approved these changes
Jan 22, 2025
dongsug-song
force-pushed
the
DevelNUI
branch
from
February 4, 2025 12:19
c9eda11
to
772cc29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support full screen mode of the input panal.
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/318558
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/318559