Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(launcher): add RunningStep interface #728

Merged
merged 7 commits into from
Aug 3, 2022

Conversation

miltolstoy
Copy link
Collaborator

Refactoring according to this comment:

Instead of returning tuple, I suggest to perform some refactoring:

1. Declare interface for running step explicitly, as an abstract base class

2. Use type declaration of this interface for type checking with mypy

3. Include error status into this interface instead of returning it from the "start" and "finalize" functions separately

4. Pass the object into active_background_steps instead of passing separate methods

universum/modules/launcher.py Outdated Show resolved Hide resolved
@miltolstoy miltolstoy requested a review from k-dovgan August 1, 2022 06:31
@miltolstoy miltolstoy requested review from axxie and i-keliukh and removed request for axxie August 2, 2022 04:54
@miltolstoy miltolstoy requested review from i-keliukh and removed request for axxie August 3, 2022 04:43
@miltolstoy miltolstoy merged commit 704a180 into master Aug 3, 2022
@miltolstoy miltolstoy deleted the running_step_interface branch August 3, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants