Add wasi functions required by quickjs #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add numerous wasi functions required to run quickjs engine. Also add test case for functions. Also fix a small bug with accessing an empty vector's element. Signed-off-by: Ádám László Kulcsár <[email protected]>
kulcsaradam
commented
Jan 30, 2025
| @@ -638,7 +638,7 @@ class WASMBinaryReader : public wabt::WASMBinaryReaderDelegate { | |||
| * | |||
| * m_currentFunction->peekByteCode<Walrus::UnaryOperation>(m_lastI32EqzPos)->dstOffset() == stackPos | |||
| * checks if the output of I32Eqz is the input of JumpIfTrue/JumpIfFalse | |||
| */ | |||
| */ | |||
There was a problem hiding this comment.
This change was made by the clang-format. I do not know why it was not discovered before.
kulcsaradam
commented
Jan 30, 2025
| F(fd_prestat_get, I32I32_RI32) \ | ||
| F(fd_prestat_dir_name, I32I32I32_RI32) \ |
There was a problem hiding this comment.
I moved this definition so functions follow the order of the specifications so it's a bit easier to search.
kulcsaradam
force-pushed
the
quickjs_wasi
branch
from
0cc5b3f to
f07539c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add numerous wasi functions required to run quickjs engine. Also add test case for functions.
Also fix a small bug with accessing an empty vector's element.