Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ASCII Reader for the refactor branch #105

Open
wants to merge 70 commits into
base: refactor_24
Choose a base branch
from
Open

New ASCII Reader for the refactor branch #105

wants to merge 70 commits into from

Conversation

jamescrake-merani
Copy link

This is just for the refactor branch. We'll probably do a more thorough review when the refactor branch is due to be merged into main (or in this case 'master').

@jamescrake-merani
Started with the basic ascii reader func signature
36cbeeb
@jamescrake-merani
Param for excldued lines.
8d56d69
@jamescrake-merani
Function to read in quantities.
20ebf35
@jamescrake-merani
Created load_data function.
93e6e96
@jamescrake-merani
Added a dataclass for the reader params.
b02ecc2
@jamescrake-merani
Use the new data class.
1b5b74f
@jamescrake-merani
Doesn't look like this is used atm.
c93c449
@jamescrake-merani
Fixed import errors.
c2fd3d0 
I can't get the ASCII dialog to run when using relative imports in these
files so I've converted them to absolute imports.
@jamescrake-merani
Forgot to pass current_line :P
2c5195d
@jamescrake-merani
I think i, and j were the wrong way round.
498112b
@jamescrake-merani
Ignore if there are extra columns.
b618a15
@jamescrake-merani
Merge branch 'refactor_24' into 88-make-readers-return-sasdata-objects
7c906e8
@jamescrake-merani
Added a metadata param.
48dd8f1
@jamescrake-merani
Added a comment for the raw metadata.
120fe41
@jamescrake-merani
Created a temp value for metadata.
3390f86
@jamescrake-merani
Need to return the Group not metadata object.
d43c8d5
@jamescrake-merani
Whoops misssing bracket.
4dac69f
@jamescrake-merani
Nvm there were actually too many.
c918934
@jamescrake-merani
Don't include zeros below starting line.
d905d90
@jamescrake-merani
Test for loading metadata.
79430db
@jamescrake-merani
Mechanism for converting the gui data.
2fd2811
@jamescrake-merani
Use the new function to load in the metadata.
da77849
@jamescrake-merani
Merge the uncertainties.
5951777 
So they do not appear as a separate column.
@jamescrake-merani
Forgot to specify name.
4bd320f
@jamescrake-merani
Need to strip the line.
b83460c
@jamescrake-merani
Moving internal metadata to sasdata.
d9a17bb 
This is going to need to live here now in order to avoid circular dependencies.
@jamescrake-merani
Changes to ascii reader params.
f2d635a 
So that we can read multiple files at the same time.
@jamescrake-merani
Load quantities should load multiple files.
86812ce
@jamescrake-merani
Function for getting all of the metadata for file.
afbfa37
@jamescrake-merani
Updated the conversion to the backing data.
6bf4176
jamescrake-merani and others added 28 commits December 11, 2024 15:06
@jamescrake-merani
I think capture should default to false.
dbaedde
@jamescrake-merani
Added function to purge unreachable metadata.
6410cfc
@jamescrake-merani
Fill in the pairings.
e83b7fb
@jamescrake-merani
Removed old comment.
29acfdc
@jamescrake-merani
Pairings for columns, and their uncertainties.
d872801
@jamescrake-merani
Method to init separator for filename.
bf4962b
@jamescrake-merani
Line difference.
f918e5c
@jamescrake-merani
Remove this comment as it will no longer be true.
1edc4a6
@jamescrake-merani
Call items method.
e9c468a 
If this is a dict then we can't destructure it without calling items.
@jamescrake-merani
Need to keep a separate dict.
0dc583d 
So that we can get all of the uncertainty columns only.
@jamescrake-merani
Set some default values for the reader params.
cd241c1 
This is to make it easier to call this outside of the reader dialog GUI.
@jamescrake-merani
Created an init method for the ascii reader params
6007a86
@jamescrake-merani
use post init instead.
54f272d 
This seems to be a cleaner solution.
@jamescrake-merani
Accidentally deleted columns param.
10242ae
@jamescrake-merani
Forgot to set the defalt value for this.
f69b7ae
@jamescrake-merani
Fixed typo in todo comment.
1e8f446
@jamescrake-merani
This should be false by default.
8a84b2e
@jamescrake-merani
Add a default value for metadata.
707f43a 
So that we don't have to initialise it when calling it.
@jamescrake-merani
This is probably better than default factory.
8d792ac
@jamescrake-merani
Changed my mind again on initing the metadata.
814599a
@jamescrake-merani
Typo in post init method name.
22d064e
@jamescrake-merani
Wrote some docstrings.
9011680
@jamescrake-merani
Add a docstring for the params class.
44b9f56
@jamescrake-merani
Merge branch 'refactor_24' into 88-make-readers-return-sasdata-objects
d54ee7a
@jamescrake-merani
Fixed line endings.
2365b84 
I think I resolved a merge conflict incorrectly.
@jamescrake-merani
Remove todo comment.
c44b505
@jamescrake-merani
Added docstrings.
3fdb8c7
@jamescrake-merani
Remove this.
29d1b57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-wilkins lucas-wilkins Awaiting requested review from lucas-wilkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamescrake-merani