-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SasData counterpart to SasView SlicerExtension_1344 #61
SasData counterpart to SasView SlicerExtension_1344 #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure all of this is necessary. A couple of potential simplifications are suggested, assuming I understand the logic fully.
Co-authored-by: Jeff Krzywon <[email protected]>
…licerExtension_1344' into SasData-Counterpart-to-Sasview-SlicerExtension_1344
Once approved and merged, this should also be merged into 0.9 along with SasView Slicer Extension_1344 assuming that happens. |
Functionality testing the installer of the sasview counterpart, with this branch of sasdata, on windows 10 works beautifully. |
Correction to _Slab in manipulations.py which is used for the box slicers introduced in SlicerExtension_1344.
This should be pushed/rejected with SlicerExtension_1344