Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SasData counterpart to SasView SlicerExtension_1344 #61

Merged

Conversation

jack-rooks
Copy link
Contributor

Correction to _Slab in manipulations.py which is used for the box slicers introduced in SlicerExtension_1344.

This should be pushed/rejected with SlicerExtension_1344

Copy link
Collaborator

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure all of this is necessary. A couple of potential simplifications are suggested, assuming I understand the logic fully.

sasdata/data_util/manipulations.py Outdated Show resolved Hide resolved
sasdata/data_util/manipulations.py Outdated Show resolved Hide resolved
sasdata/data_util/manipulations.py Show resolved Hide resolved
@butlerpd
Copy link
Member

Once approved and merged, this should also be merged into 0.9 along with SasView Slicer Extension_1344 assuming that happens.

@krzywon krzywon changed the base branch from master to release_0.9.0 February 16, 2024 18:11
@butlerpd
Copy link
Member

Functionality testing the installer of the sasview counterpart, with this branch of sasdata, on windows 10 works beautifully.

@krzywon krzywon merged commit c350b9a into release_0.9.0 Apr 23, 2024
18 checks passed
@krzywon krzywon deleted the SasData-Counterpart-to-Sasview-SlicerExtension_1344 branch April 23, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants