Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delta in sesans docs #65

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

caitwolf
Copy link
Contributor

Fixed delta symbols from changes made in PR #60 that were not rendering properly in the docs.

@caitwolf
Copy link
Contributor Author

caitwolf commented Mar 19, 2024

@butlerpd I created a temporary branch in SasView that uses this sasdata branch to generate the installers. The correct installers for review of this PR can be found at:
https://github.com/SasView/sasview/actions/runs/8348166833

The SasView branch at https://github.com/SasView/sasview/tree/check_fix_delta_in_sesans_docs can be deleted after this PR is merged in sasdata.

@caitwolf caitwolf requested a review from butlerpd March 19, 2024 20:58
Copy link
Member

@butlerpd butlerpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good and tested installer. Ready to merge

@butlerpd butlerpd merged commit 80f6739 into release_0.9.0 Mar 19, 2024
18 checks passed
@butlerpd butlerpd deleted the fix_delta_in_sesans_docs branch March 19, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants