-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Branch #79
base: master
Are you sure you want to change the base?
Conversation
…ions Refactor 24 73 file type descriptions
76 basic outline of new data types
76 basic outline of new data types
Unit parsing
For now, I'm just specifying all of them in the regex. This should work for now because there aren't many symbols to specify, and I'm not sure what else would work without allowing symbols that shouldn't really be allowed.
Unit unicode symbol fix
… refactor_24 # Conflicts: # sasdata/quantities/accessors.py # sasdata/temp_hdf5_reader.py
…ns for ineptitudes.
sasdata/transforms/operation.py
Outdated
@@ -0,0 +1,19 @@ | |||
import numpy as np | |||
from sasdata.quantities.quantity import Quantity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this file be deleted now? Seems to just be a sketch which has now been implemented in operations.py
.
|
||
entry_keys = [key for key in entry.keys()] | ||
|
||
if "sasdata" not in entry_keys and "data" not in entry_keys: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this account for the situation where entry_keys
contains something like 'sasdata01'
?
Main branch for the refactoring project