Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read OOMMF V2 files #2060

Closed
dehoni opened this issue Jun 6, 2022 · 3 comments · Fixed by #2061
Closed

read OOMMF V2 files #2060

dehoni opened this issue Jun 6, 2022 · 3 comments · Fixed by #2061
Assignees
Labels
Enhancement Feature requests and/or general improvements Scattering Calculator Tool Concerns scattering calculator

Comments

@dehoni
Copy link
Contributor

dehoni commented Jun 6, 2022

omv files created with OOMMF are shlightly different to what the GSC expects as input for magnetic files, e.g. the entry "valuemultiplier", "valuerangeminmag", "valuerangemaxmag" are optional, and "valueunit" can provide a value for each dimension.

The OMFReader should be able to handle the different cases.

@dehoni dehoni self-assigned this Jun 6, 2022
@dehoni dehoni added Scattering Calculator Tool Concerns scattering calculator Enhancement Feature requests and/or general improvements labels Jun 6, 2022
@dehoni dehoni added this to the SasView Next Release +1 milestone Jun 6, 2022
@dehoni dehoni linked a pull request Jun 6, 2022 that will close this issue
@dehoni
Copy link
Contributor Author

dehoni commented Jun 6, 2022

The entries "valuerangeminmag", "valuerangemaxmag" are actually never used later in the GCS. I commented them out for the moment. The other issues are handled such that the reader accepts files in the omf format seen so far.

@dehoni
Copy link
Contributor Author

dehoni commented Jun 7, 2022

isolated_sk_T-Oxs_MinDriver-Magnetization-00-0000217.omf.txt
isolated_skyrmion.omf.txt
The two files are identical except of the header, which is OMF V2.0 for the first file and a V1 version called isolated_skyrmion.omf.

@dehoni
Copy link
Contributor Author

dehoni commented Jun 7, 2022

The PR should provide a unit test, and a more meaningful message stating Version loaded. For failure the error message "We accept only Text format OMF file." is not specific enough, test if it is a omf file and where it fails (e.g. missing variable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Scattering Calculator Tool Concerns scattering calculator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant