Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide test data for GSC in test folder and update documentation #2076

Merged
merged 3 commits into from
Jun 16, 2022
Merged

provide test data for GSC in test folder and update documentation #2076

merged 3 commits into from
Jun 16, 2022

Conversation

dehoni
Copy link
Contributor

@dehoni dehoni commented Jun 15, 2022

No description provided.

@dehoni dehoni added Enhancement Feature requests and/or general improvements Testing Testing and quality labels Jun 15, 2022
@dehoni dehoni requested a review from wpotrzebowski June 15, 2022 12:52
@dehoni dehoni self-assigned this Jun 15, 2022
@dehoni dehoni linked an issue Jun 15, 2022 that may be closed by this pull request
Test data for generic scattering calculator #2069
Closed
krzywon
krzywon approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dehoni, are these oomf v2 files, in which case, this would be related to issue #2060 and PR #2061? In either case, this is an innocuous change that adds more example data and lays the groundwork for adding unit tests.

I haven't tested loading the files using the scattering calculator and would suggest someone do that before merging.

@wpotrzebowski
Copy link
Contributor

I will test the files. Quick question. I guess we want to merge to main not env_setup?

@wpotrzebowski
Copy link
Contributor

All files are loading and GSC works on them. The minor thing that I spotted is that tooltip on Load button doesn't list vtk format.

wpotrzebowski
wpotrzebowski approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@wpotrzebowski wpotrzebowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably fix the typo (and maybe tooltip) but otherwsie good to go.

src/sas/qtgui/Calculators/media/gsc_ex_magnetic_cylinder.rst Outdated Show resolved Hide resolved
@dehoni
Copy link
Contributor Author

dehoni commented Jun 16, 2022

@dehoni, are these oomf v2 files, in which case, this would be related to issue #2060 and PR #2061? In either case, this is an innocuous change that adds more example data and lays the groundwork for adding unit tests.

I haven't tested loading the files using the scattering calculator and would suggest someone do that before merging.

The omf files are a separate issue (with a bit of discussion how to go forward). Here it is only sld and vtk files.

@wpotrzebowski wpotrzebowski merged commit d4303f5 into env_setup Jun 16, 2022
@wpotrzebowski wpotrzebowski deleted the ticket-2069-GSC-test-data branch June 16, 2022 13:49
@wpotrzebowski wpotrzebowski restored the ticket-2069-GSC-test-data branch June 16, 2022 15:42
@wpotrzebowski wpotrzebowski deleted the ticket-2069-GSC-test-data branch June 16, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzywon krzywon krzywon approved these changes

@wpotrzebowski wpotrzebowski wpotrzebowski approved these changes

Assignees

@dehoni dehoni

Labels
Enhancement Feature requests and/or general improvements Testing Testing and quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test data for generic scattering calculator
3 participants
@dehoni @wpotrzebowski @krzywon