Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute button does nothing when there is data in the fit page (Trac #694) #823

Closed
ajj opened this issue Mar 30, 2019 · 1 comment
Closed
Assignees
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@ajj
Copy link
Member

ajj commented Mar 30, 2019

When data is present in the fit page, the compute button does nothing.

Pressing enter in value fields does recompute the model.

This worked in 3.1.2

Migrated from http://trac.sasview.org/ticket/694

{
    "status": "closed",
    "changetime": "2016-10-05T15:06:06",
    "_ts": "2016-10-05 15:06:06.451098+00:00",
    "description": "When data is present in the fit page, the compute button does nothing.\n\nPressing enter in value fields does recompute the model.\n\nThis worked in 3.1.2",
    "reporter": "ajj",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-05T14:44:57",
    "component": "SasView",
    "summary": "Compute button does nothing when there is data in the fit page",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "ajj",
    "type": "defect"
}
@ajj ajj added this to the SasView 4.1.0 milestone Mar 30, 2019
@ajj ajj self-assigned this Mar 30, 2019
@ajj ajj added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@ajj
Copy link
Member Author

ajj commented Mar 30, 2019

Trac update at 2016/10/05 15:06:06:

  • ajj commented:

In changeset c65a265:

#!CommitTicketReference repository="sasview" revision="c65a265f903fc473c9bca504ea24f9bb02d98193"
Removing logic that caused compute button to do nothing when data was present in the fit page.

Fixes #823
  • ajj changed resolution from "" to "fixed"
  • ajj changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

1 participant