Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Check packages comparison to YAML files #1482

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Mar 19, 2020

As suggested yesterday, check_packages.py in master now compares the appropriate yaml file against what is currently installed on the users system. I've added two new dependencies that might need to be incorporated into the existing yaml files, but I only have a Windows system right now. The 5.x fix is a little more complex due to the number of yaml files in the branch so I haven't finished it yet.

Features:

  • Checks the installed packages against the yaml file, including version numbers
  • Flags packages that aren't installed as a major issue
  • Flags packages with unexpected or unknown versions as a minor issue

Possible TODOs:

  • Add PyYaml and colorama to the dependency files

@pkienzle
Copy link
Contributor

On Mac conda, I needed to install PyYAML via pip since the conda yaml package didn't work on python 2.7:
pip install pyyaml
I also needed to install the colorama package.

@smk78
Copy link
Contributor

smk78 commented Mar 21, 2020

Once I installed pyyaml in my Anaconda2/Win10/x64 environment and rebuilt this branch check_packages worked a dream.

@pkienzle
Copy link
Contributor

Now that I remember that you need to conda search "*yaml*"' I see that PyYAML **is** available within conda using conda install pyyaml`. This works for me as well.

@butlerpd
Copy link
Member

We know why tests are failing and that fix is already in master (problem with travis.yml). So what else is needed to approve this one? seems like it is similar to 5.x which was approved? or is it more complicated than that?

@butlerpd butlerpd merged commit c470220 into master Mar 31, 2020
@krzywon krzywon deleted the 4x_yaml_check_packages branch March 31, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure GitHub, project structure, community etc
Projects
None yet
4 participants