Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation sasview developers_Convert UI does not create output if a space is present in thefolder name in the path #2783

Closed
wants to merge 265 commits into from

Conversation

MariannaGerina
Copy link
Contributor

Description

During the installation of sasview developers enviroment, this kind of error was happaneng (see picture below):
Pull request
The ConvertUI in qtgui was not able to create the output file.

Fixes # (issue/issues)
Properly quoted files name in the convertor UI file, i.e run_line = f'pyside6-rcc "{in_file}" -o "{out_file}"'

How Has This Been Tested?

Review Checklist (please remove items if they don't apply):

  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)

XaelShan added 30 commits June 27, 2023 11:48
…not written, opt_in code not written, models not importable yet
Wojciech Potrzebowski and others added 21 commits January 15, 2024 15:58
…n a pop up window when slit width is set larger than slit length
…or-logging-in-smearingwidget

added missing import statement for logging to enable error messages i…
…ening-a-project

2712 annoying behaviour when opening a project
…ransform and disabled as there is no other resolution for SESANS
2746 fixed running tests locally
…displaying-correct-information-when-sesans-data-loaded

Made changes to fitting perspective for sesans data
@wpotrzebowski
Copy link
Contributor

@MariannaGerina It seems like you committed changes to the main branch and therefore there are many changes and conflicts. The easiest (in my opinion)to fix it is to create a new branch and set main as base branch (I guess you want to make changes to main not release_6.0.0?).

@MariannaGerina
Copy link
Contributor Author

MariannaGerina commented Jan 22, 2024

@wpotrzebowski Yes, probably it's better. Should I close the pull request?

The results panel window is updated when a bumps fit is run. It is held in GuiManager and never closed. I'm merging this.
@butlerpd
Copy link
Member

DO NOT MERGE -- MISTAKE

@butlerpd butlerpd closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.