Code

Update model editor#2918

Code

Closed

tsole0 wants to merge 43 commits intorelease_6.0.0SasView/sasview:release_6.0.0from update-model-editorSasView/sasview:update-model-editorCopy head branch name to clipboard

+1,081-304

Commits

Commits on Jun 18, 2024

• Adds ER and VR functions to non-polydisperse model and fixes whitespace

  tsole0

  committed
  d28cba7

• Create Form Volume Function text editing box in UI

  tsole0

  committed
  dd7819a

Commits on Jun 20, 2024

• allows user to edit form volume function in GUI if polydisperse params exist

  tsole0

  committed
  98c0a31

• polydisperse-only functions are omitted from model text if Form Volume Function text box is hidden

  tsole0

  committed
  6dc2f84

• Fixes pre-existing bug forcing user to re-enter default text for model file to generate

  tsole0

  committed
  ba4cbc7

• "smart" example text now automatically appears in Form Volume function box

  tsole0

  committed
  b35ee1c

Commits on Jun 21, 2024

• Change tooltips, GUI discriptions, and sample functions for clarity

  tsole0

  committed
  3ea3929

• fixes bug preventing applying model changes from model editor

  tsole0

  committed
  0435372

Commits on Jun 24, 2024

• Adds all python flags to the model template with default values

  tsole0

  committed
  b3bc16f

• Add checkboxes for generating Python and C code in PluginDefinition UI

  Show description for 1251c38
  tsole0

  committed
  1251c38

• Connect checkboxes to logic that creates new tab for displaying C model and saves as a .c file

  tsole0

  committed
  bb37054

Commits on Jun 25, 2024

• Add error message QMessageBox if user does not specify which model languages to generate

  tsole0

  committed
  54b1159

• Update error text for clarity and readability

  tsole0

  committed
  bb61fb7

• linting within updateFromPlugin(), create C_TEMPLATE for use in creating C model template, connect so that it writes template to .c file and formats with user-input parameters

  tsole0

  committed
  84c7bdb

Commits on Jun 26, 2024

• fix bug preventing c template generation if no polydisperse params were specified by separating pd-dependent funcs into C_PD_TEMPLATE and only including it if pd params exist

  tsole0

  committed
  f16633f

• add source = [] statement to python model if user creates both python and C models, linking them.

  tsole0

  committed
  27ac6d6

Commits on Jun 27, 2024

• add descriptive comments to C model template variable, include have_fq flag into python template by default

  tsole0

  committed
  5ccb501

• Cherry-pick bug-fix branch to gain unit tests for model checking on plugin editor changes

  Show description for 26e6b59
  tsole0

  committed
  26e6b59

• remove isModelCorrect method whose functionality was incorporated into checkModel in previous commit

  tsole0

  committed
  e3e0073

• Update comments and remove unnecessary flag from method

  tsole0

  committed
  de25165

• when saving C model, run model check and highlight C window if error with C code. Clear highlights from both python and C windows if checks pass. Ensure that checkModel() is always passed a path ar…

  Show description for 0c61d51
  tsole0

  committed
  0c61d51

• fix bug that deletes .py file after a failed model check on a .c file by removing os.remove(). allow user to load .c models into editor even if .c file fails model checks

  tsole0

  committed
  a1d04b3

• remove references to deprecated self.filename variable; in both cases self.filename_py works fine.

  tsole0

  committed
  2cc5296

Commits on Jun 28, 2024

• add overridewarning() function that allows user to save model even if bad model check via QMessageBox prompt. This ensures no bad models are written to files without user agreement. Define full_pat…

  Show description for 20212f6
  tsole0

  committed
  20212f6

• add noModelCheckWarning() method to show popup if user generates only C model because no model checks can be run without a python wrapper. add showNoCompileWarning so user can override dialog after…

  Show description for faefb31
  tsole0

  committed
  faefb31

• Merge remote-tracking branch 'origin/release_6.0.0' into update-model-editor

  tsole0

  committed
  d1871c9

• retain error formatting if the user decides to override bad model warning

  tsole0

  committed
  7790233

• expand QTableWidget horizontally to fit area, and ensure that text doesn't wrap in QTableWidget headers

  tsole0

  committed
  068cdb1

• simplify and centralize tab creation methods into addTab() and removeTab(). Initialize c_editor_widget in addWidgets(), only add editor widgets if needed, do not add widgets if one of same type alr…

  Show description for 8bf8960
  tsole0

  committed
  8bf8960

• update tab names if user changes model name

  tsole0

  committed
  3c26555

• Merge remote-tracking branch 'origin/release_6.0.0-macos13' into update-model-editor

  tsole0

  committed
  bb48ac8

Commits on Jul 2, 2024

• fix bug preventing editing models in model editor because editorModelModified signal was not connected

  tsole0

  committed
  8f7f7f2

Commits on Jul 3, 2024

• force user to generate Python model if no Python model is detected in user plugins directory, display helper text and disable checkbox.

  tsole0

  committed
  10db795

• cause modelModified signal to be emitted when text changed instead of editing finished

  tsole0

  committed
  33530b1

• Adds comment explaining built-in functions to C template

  tsole0

  committed
  fe46afe

• edits previously mentioned comment for clarity

  tsole0

  committed
  d2deaa3

Commits on Jul 5, 2024

• reflect user changes to model editor in plugin editor. use ast module to find function text, load model using importlib.util to find access variables.

  tsole0

  committed
  98773f4

• fix indentation in auto-generated c models

  tsole0

  committed
  c1be4dd

• make comments multi-line to improve readability in editor window

  tsole0

  committed
  70f08a6

Commits on Aug 23, 2024

• Merge remote-tracking branch 'origin/release_6.0.0' into update-model-editor

  tsole0

  committed
  057debf

Commits on Sep 9, 2024

• Merge remote-tracking branch 'origin/release_6.0.0' into update-model-editor

  tsole0

  committed
  dc0df1c

• add checkboxes for boolean flags in model editor

  tsole0

  committed
  4e6e69e

Commits on Sep 12, 2024

• update C template and "generate C model checkbox" for clarity

  tsole0

  committed
  bb0b27d