Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2993 ascii file reader options #3007

Draft
wants to merge 391 commits into
base: refactor_24
Choose a base branch
from
Draft

2993 ascii file reader options #3007

wants to merge 391 commits into from

Conversation

jamescrake-merani
Copy link
Contributor

Created a prototype dialog menu for selecting various parameters for reading in an ASCII dataset file.

@jamescrake-merani
Removed commented out code.
96f9596
@jamescrake-merani
Added some docstrings.
eb975c8
@jamescrake-merani
Added docstring.
f094701
@jamescrake-merani
Documented warning label class.
4d31523
@jamescrake-merani
Remove unneeeded import.
f57aaca
@jamescrake-merani
Removed some old comments.
7c23af1
@jamescrake-merani
Document col editor.
01c20b6
@jamescrake-merani
I don't think this function is being used anymore.
1e57d3e
@jamescrake-merani
Remove import.
1ffe53b
@jamescrake-merani
Fixed bug with the regex.
ae3b7d6
@jamescrake-merani
Move init to top.
cc78b3c
@jamescrake-merani
Move init to top.
0a448df
@jamescrake-merani
Fixed typo.
afed9f5
@jamescrake-merani
Some more docstrings.
2b6d224
@jamescrake-merani
Use dictionary for looking up dataset.
c35ab0b
@jamescrake-merani
More docstrings.
269f63a
@jamescrake-merani
Return a set instead of a list.
94846ac
@jamescrake-merani
Use elipsis to indicate there is more data.
19d8bf4
@jamescrake-merani
Allign the elipsis.
2444fbc
@jamescrake-merani
Don't need a seperate for loop for typesetting.
d1a8e02
@jamescrake-merani
Moved where the check for max row happens.
441372f
@jamescrake-merani
Rename parameter.
99d059f
@jamescrake-merani
Don't count multiple ignores as duplicates.
58ffb24
@jamescrake-merani
Method for determining options.
6df877e
@jamescrake-merani
Removed redundant var.
4b524ac
@jamescrake-merani
Removed imports not being used anymore.
a2ddad8
@jamescrake-merani
Added exception handling for reading the file.
6af85cc
@jamescrake-merani
Default to using the character.
f8d86ee
@jamescrake-merani
Use a separate propety for the expression.
55e63ec
@jamescrake-merani
Split on casing as well.
1a28f39
@jamescrake-merani
Use new constant for casing regex.
ff2f981
@jamescrake-merani
Try hooking up to this event.
17f0020
@jamescrake-merani
We should probably use our internal split function.
8d39ed0
@jamescrake-merani
Fixed regex.
fa15585
@jamescrake-merani
Was using the wrong event.
216a8f4
@jamescrake-merani
Changed where options is generated.
6c689bd
@jamescrake-merani
Need to set this earlier to stop the event firing
38b86e9
@jamescrake-merani
This shouldn't be here anymore.
7e1b60e
@jamescrake-merani
These functions aren't needed anymore.
64194f4
@jamescrake-merani
Update the separator before updating stuff.
75a06e7
@jamescrake-merani
Call purge unreachable on separator update.
9248d88
@jamescrake-merani
Disable the separator box if casing is enabled.
7f2cb4a
@jamescrake-merani
Return unformatted if we're using casing separation.
c407b24
@jamescrake-merani
Fixed error when there are no capital letters.
a03290d
@jamescrake-merani
Use a property for starting pos.
950cd04 
So this can be represented in 1 based indexing for the user.
@jamescrake-merani
Update warning on selection/deselection.
d41fbd7
@jamescrake-merani
Add a setter for the current unit.
6eddc96
@jamescrake-merani
Make sure units match on uncertanties.
4f61e15
@jamescrake-merani
Trigger column changed when the unit changes.
4446b41
@jamescrake-merani
Stop event triggering when unit is empty.
eb3c15b
@jamescrake-merani
Make sure ALL the columns are numbers.
2bc464e
@jamescrake-merani
Use the new init separator method for the metadata.
7ec2f80
@jamescrake-merani
Merge branch 'refactor_24' into 2993-ascii-file-reader-options
50bf23a
@jamescrake-merani
Should just be using split line from the reader.
9c391e6 
To reduce code duplication.
@jamescrake-merani
Shouldn't be calling items here.
0514fe5
@jamescrake-merani
Convert to list to make the interpreter happy.
ba95c60
@jamescrake-merani
This isn't true anymore.
91777ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-wilkins lucas-wilkins lucas-wilkins left review comments

@rozyczko rozyczko rozyczko left review comments

@pkienzle pkienzle pkienzle left review comments

Assignees

@lucas-wilkins lucas-wilkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamescrake-merani @rozyczko @pkienzle @lucas-wilkins