Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC1: Fix for the release #3117

Merged
merged 4 commits into from
Oct 4, 2024
Merged

RC1: Fix for the release #3117

merged 4 commits into from
Oct 4, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Oct 3, 2024

Description

This sets the config version back to 6.0.0. This should fix the issue with the release candidate.

Review Checklist:

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@wpotrzebowski wpotrzebowski added the SasView 6.0.0 Required for 6.0.0 release label Oct 4, 2024
Copy link
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality test of artefact https://github.com/SasView/sasview/actions/runs/11167505645/job/31080657249?pr=3117 on W10/x64.
Installed, ran, and re-ran fine. The bug seems fixed.

@lucas-wilkins
Copy link
Contributor

Windows one seems good. Trying to find the mac artefact.

@lucas-wilkins
Copy link
Contributor

@krzywon The mac artefact seems to be missing.

@lucas-wilkins
Copy link
Contributor

Ah, looks like its being published and deleted. Following the link in the installer script.

@krzywon
Copy link
Contributor Author

krzywon commented Oct 4, 2024

At the top, look for job runs. The Mac installer is in the first run.

@lucas-wilkins
Copy link
Contributor

@lucas-wilkins
Copy link
Contributor

I'd say both mac and windows are good to go!

@krzywon
Copy link
Contributor Author

krzywon commented Oct 4, 2024

I also tested both Mac builds on a Silicon based Mac. They both load, though the Intel-based build does take a while to load the first time. I'm going ahead and merging this and will have RC2 available once the merged build is finalized.

@krzywon krzywon merged commit 95b4fb8 into release_6.0.0 Oct 4, 2024
36 checks passed
@krzywon krzywon deleted the fix-rc1 branch October 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SasView 6.0.0 Required for 6.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants