-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC1: Fix for the release #3117
RC1: Fix for the release #3117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality test of artefact https://github.com/SasView/sasview/actions/runs/11167505645/job/31080657249?pr=3117 on W10/x64.
Installed, ran, and re-ran fine. The bug seems fixed.
Windows one seems good. Trying to find the mac artefact. |
@krzywon The mac artefact seems to be missing. |
Ah, looks like its being published and deleted. Following the link in the installer script. |
At the top, look for job runs. The Mac installer is in the first run. |
Checked this: https://github.com/SasView/sasview/actions/runs/11167505645/artifacts/2012513640 Looks fine. |
I'd say both mac and windows are good to go! |
I also tested both Mac builds on a Silicon based Mac. They both load, though the Intel-based build does take a while to load the first time. I'm going ahead and merging this and will have RC2 available once the merged build is finalized. |
Description
This sets the config version back to 6.0.0. This should fix the issue with the release candidate.
Review Checklist:
Installers
Licencing (untick if necessary)