Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SciLifeLab logo to About box #3124

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Adding SciLifeLab logo to About box #3124

merged 1 commit into from
Oct 16, 2024

Conversation

wpotrzebowski
Copy link
Contributor

Description

Adding SciLifeLab logo to About dialog

How Has This Been Tested?

Open SasView go to Help/About and see if it looks like

Screenshot 2024-10-15 at 20 34 12

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@wpotrzebowski wpotrzebowski marked this pull request as ready for review October 15, 2024 19:41
krzywon
krzywon approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is bundled with the Windows installer and looks good.

@krzywon krzywon merged commit 17ea162 into release_6.0.0 Oct 16, 2024
34 checks passed
@krzywon krzywon deleted the release_6.0.0_scilifelab_logo branch October 16, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzywon krzywon krzywon approved these changes

@lucas-wilkins lucas-wilkins Awaiting requested review from lucas-wilkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpotrzebowski @krzywon