Code

Update model editor (rebase)#3135

Code

Draft

krzywon wants to merge 39 commits intomainSasView/sasview:mainfrom update-model-editor-rebaseSasView/sasview:update-model-editor-rebaseCopy head branch name to clipboard

+1,081-304

Commits

Commits on Oct 25, 2024

• Adds ER and VR functions to non-polydisperse model and fixes whitespace

  

  tsole0

  authored and

  krzywon

  committed
  b713e9e

• Create Form Volume Function text editing box in UI

  

  tsole0

  authored and

  krzywon

  committed
  9a5eb5e

• allows user to edit form volume function in GUI if polydisperse params exist

  

  tsole0

  authored and

  krzywon

  committed
  7625d37

• polydisperse-only functions are omitted from model text if Form Volume Function text box is hidden

  

  tsole0

  authored and

  krzywon

  committed
  77e376f

• Fixes pre-existing bug forcing user to re-enter default text for model file to generate

  

  tsole0

  authored and

  krzywon

  committed
  c50987f

• "smart" example text now automatically appears in Form Volume function box

  

  tsole0

  authored and

  krzywon

  committed
  9cfe27d

• Change tooltips, GUI discriptions, and sample functions for clarity

  

  tsole0

  authored and

  krzywon

  committed
  0b73ba6

• fixes bug preventing applying model changes from model editor

  

  tsole0

  authored and

  krzywon

  committed
  c62ecad

• Adds all python flags to the model template with default values

  

  tsole0

  authored and

  krzywon

  committed
  5ccaa42

• Add checkboxes for generating Python and C code in PluginDefinition UI

  Show description for 15d43c6
  

  tsole0

  authored and

  krzywon

  committed
  15d43c6

• Connect checkboxes to logic that creates new tab for displaying C model and saves as a .c file

  

  tsole0

  authored and

  krzywon

  committed
  8517588

• Add error message QMessageBox if user does not specify which model languages to generate

  

  tsole0

  authored and

  krzywon

  committed
  31309b8

• Update error text for clarity and readability

  

  tsole0

  authored and

  krzywon

  committed
  a15b081

• linting within updateFromPlugin(), create C_TEMPLATE for use in creating C model template, connect so that it writes template to .c file and formats with user-input parameters

  

  tsole0

  authored and

  krzywon

  committed
  dc5a311

• fix bug preventing c template generation if no polydisperse params were specified by separating pd-dependent funcs into C_PD_TEMPLATE and only including it if pd params exist

  

  tsole0

  authored and

  krzywon

  committed
  bb83f69

• add source = [] statement to python model if user creates both python and C models, linking them.

  

  tsole0

  authored and

  krzywon

  committed
  e87d9d1

• add descriptive comments to C model template variable, include have_fq flag into python template by default

  

  tsole0

  authored and

  krzywon

  committed
  582af96

• Cherry-pick bug-fix branch to gain unit tests for model checking on plugin editor changes

  Show description for 9bf4127
  

  tsole0

  authored and

  krzywon

  committed
  9bf4127

• remove isModelCorrect method whose functionality was incorporated into checkModel in previous commit

  

  tsole0

  authored and

  krzywon

  committed
  1e2d643

• Update comments and remove unnecessary flag from method

  

  tsole0

  authored and

  krzywon

  committed
  985e6fb

• when saving C model, run model check and highlight C window if error with C code. Clear highlights from both python and C windows if checks pass. Ensure that checkModel() is always passed a path ar…

  Show description for 11c7ae1
  

  tsole0

  authored and

  krzywon

  committed
  11c7ae1

• fix bug that deletes .py file after a failed model check on a .c file by removing os.remove(). allow user to load .c models into editor even if .c file fails model checks

  

  tsole0

  authored and

  krzywon

  committed
  ac17f67

• remove references to deprecated self.filename variable; in both cases self.filename_py works fine.

  

  tsole0

  authored and

  krzywon

  committed
  a6fdee9

• add overridewarning() function that allows user to save model even if bad model check via QMessageBox prompt. This ensures no bad models are written to files without user agreement. Define full_pat…

  Show description for 5bcd5a6
  

  tsole0

  authored and

  krzywon

  committed
  5bcd5a6

• add noModelCheckWarning() method to show popup if user generates only C model because no model checks can be run without a python wrapper. add showNoCompileWarning so user can override dialog after…

  Show description for 3196d58
  

  tsole0

  authored and

  krzywon

  committed
  3196d58

• retain error formatting if the user decides to override bad model warning

  

  tsole0

  authored and

  krzywon

  committed
  a43dafa

• expand QTableWidget horizontally to fit area, and ensure that text doesn't wrap in QTableWidget headers

  

  tsole0

  authored and

  krzywon

  committed
  078b2cc

• simplify and centralize tab creation methods into addTab() and removeTab(). Initialize c_editor_widget in addWidgets(), only add editor widgets if needed, do not add widgets if one of same type alr…

  Show description for 4ffa597
  

  tsole0

  authored and

  krzywon

  committed
  4ffa597

• update tab names if user changes model name

  

  tsole0

  authored and

  krzywon

  committed
  726eb1d

• fix bug preventing editing models in model editor because editorModelModified signal was not connected

  

  tsole0

  authored and

  krzywon

  committed
  778bffc

• force user to generate Python model if no Python model is detected in user plugins directory, display helper text and disable checkbox.

  

  tsole0

  authored and

  krzywon

  committed
  b9e43f8

• cause modelModified signal to be emitted when text changed instead of editing finished

  

  tsole0

  authored and

  krzywon

  committed
  8ab80a8

• Adds comment explaining built-in functions to C template

  

  tsole0

  authored and

  krzywon

  committed
  0fc91ff

• edits previously mentioned comment for clarity

  

  tsole0

  authored and

  krzywon

  committed
  b369d56

• reflect user changes to model editor in plugin editor. use ast module to find function text, load model using importlib.util to find access variables.

  

  tsole0

  authored and

  krzywon

  committed
  2f1d5da

• fix indentation in auto-generated c models

  

  tsole0

  authored and

  krzywon

  committed
  3551a1f

• make comments multi-line to improve readability in editor window

  

  tsole0

  authored and

  krzywon

  committed
  50962a4

• add checkboxes for boolean flags in model editor

  

  tsole0

  authored and

  krzywon

  committed
  c0591a0

• update C template and "generate C model checkbox" for clarity

  

  tsole0

  authored and

  krzywon

  committed
  b6c4a63