-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add unit tests for AboutUs component #65
feat: Add unit tests for AboutUs component #65
Conversation
Hi @Dripcoding , After the last commit which you made, one of the job is failing with error:
can you please have a look and fix it. thanks, |
@preetkaran20 This PR contains the fix for the issue you mentioned. I've confirmed this by running |
Right, we do that as well but now sure why it failed. Let me see that |
added PR: #66 for handling npm run build in PR creation as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow!!! Amazing work. LGTM.
One suggestion, please write a document that can help the future contributors on how to generate snapshots, write unit test cases, contribute to the Project and may be best practises.
@Dripcoding Invited you to thanks, |
@preetkaran20 thanks Karan! I'm happy to contribute to the project :) I've opened this issue for documentation #67 |
Add unit tests for AboutUs page