Added unit test cases for Preflight Controller #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please let me know why the pipeline failed? |
Hi, you need to run |
| import java.io.InputStream; | ||
|
|
||
|
|
||
| public class FileReader { |
There was a problem hiding this comment.
I think you have created this class such that you can mock the readAsStream functionality right?
I think you don't need a different class, create a spy of PreflightController in test class and a method in PreflightController which you can mock using spy and everything else will work perfectly.
There was a problem hiding this comment.
Yes, that was the purpose for the class.
Ok. I will make the changes.
| public class PreflightControllerTest { | ||
|
|
||
| @Mock | ||
| UnrestrictedFileUpload unrestrictedFileUpload; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #399