Added unit test cases for Preflight Controller #422
+175
−49
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package org.sasanlabs.internal.utility; | ||
|
|
||
| import org.sasanlabs.service.vulnerability.fileupload.UnrestrictedFileUpload; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
|
|
||
| import java.io.FileInputStream; | ||
| import java.io.FileNotFoundException; | ||
| import java.io.InputStream; | ||
|
|
||
|
|
||
| public class FileReader { | ||
|
|
||
| private UnrestrictedFileUpload unrestrictedFileUpload; | ||
|
|
||
| public FileReader(UnrestrictedFileUpload unrestrictedFileUpload) { | ||
| this.unrestrictedFileUpload = unrestrictedFileUpload; | ||
| } | ||
|
|
||
|
|
||
| public InputStream readAsStream(String fileName) throws FileNotFoundException { | ||
| return ( | ||
| new FileInputStream( | ||
| unrestrictedFileUpload.getContentDispositionRoot().toFile() | ||
| + FrameworkConstants.SLASH | ||
| + fileName)); | ||
| } | ||
|
|
||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| package org.sasanlabs.service.vulnerability.commandInjection.fileUpload; | ||
|
|
||
| import org.junit.jupiter.api.AfterEach; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockitoAnnotations; | ||
| import org.sasanlabs.internal.utility.FileReader; | ||
| import org.sasanlabs.internal.utility.FrameworkConstants; | ||
| import org.sasanlabs.service.vulnerability.fileupload.PreflightController; | ||
| import org.sasanlabs.service.vulnerability.fileupload.UnrestrictedFileUpload; | ||
| import org.springframework.http.HttpStatus; | ||
| import org.springframework.http.ResponseEntity; | ||
|
|
||
| import java.io.ByteArrayInputStream; | ||
| import java.io.IOException; | ||
| import java.net.URISyntaxException; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.sasanlabs.service.vulnerability.fileupload.UnrestrictedFileUpload.CONTENT_DISPOSITION_STATIC_FILE_LOCATION; | ||
|
|
||
| public class PreflightControllerTest { | ||
|
|
||
| @Mock | ||
| UnrestrictedFileUpload unrestrictedFileUpload; | ||
|
|
||
| @Mock | ||
| FileReader fileReader; | ||
| String fileName = "test.txt"; | ||
| private PreflightController preflightController; | ||
| private Path contentDispositionRoot; | ||
|
|
||
| private Path textFilePath = Paths.get(fileName); | ||
|
|
||
|
|
||
| @BeforeEach | ||
| void setUp() throws IOException { | ||
| MockitoAnnotations.initMocks(this); | ||
| Files.createFile(textFilePath); | ||
| } | ||
|
|
||
| @AfterEach | ||
| void destroy() throws IOException { | ||
| Files.delete(textFilePath); | ||
| } | ||
|
|
||
|
|
||
| @Test | ||
| void shouldBeAbleToFetchFile() throws IOException { | ||
|
|
||
| //Arrange | ||
| preflightController = new PreflightController(fileReader); | ||
| contentDispositionRoot = | ||
| Paths.get( | ||
| FrameworkConstants.SLASH | ||
| + CONTENT_DISPOSITION_STATIC_FILE_LOCATION | ||
| + FrameworkConstants.SLASH); | ||
|
|
||
| when(unrestrictedFileUpload.getContentDispositionRoot()).thenReturn(contentDispositionRoot); | ||
| when(fileReader.readAsStream(fileName)).thenReturn(new ByteArrayInputStream("test".getBytes())); | ||
|
|
||
| //Act | ||
| ResponseEntity<byte[]> responseEntity = preflightController.fetchFile(fileName); | ||
|
|
||
| //Assert | ||
| assertEquals(HttpStatus.OK, responseEntity.getStatusCode()); | ||
| verify(fileReader).readAsStream(fileName); | ||
| } | ||
|
|
||
| @Test | ||
| void shouldThrowException() throws IOException, URISyntaxException { | ||
|
|
||
| //Arrange | ||
| FileReader fileReader1 = new FileReader(new UnrestrictedFileUpload()); | ||
| preflightController = new PreflightController(fileReader1); | ||
| String anotherFileName = "test"; | ||
|
|
||
| //Act and Assert | ||
| assertThrows(IOException.class, () -> preflightController.fetchFile(anotherFileName)); | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have created this class such that you can mock the
readAsStreamfunctionality right?I think you don't need a different class, create a
spyof PreflightController in test class and a method in PreflightController which you can mock using spy and everything else will work perfectly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was the purpose for the class.
Ok. I will make the changes.