Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mocked network calls made in SSRFVulnerabilityTest." #459

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -68,24 +68,20 @@ private ResponseEntity<GenericVulnerabilityResponseBean<String>> invalidUrlRespo
MetaDataServiceMock.getResponse(u), true),
HttpStatus.OK);
} else {
return new ResponseEntity<>(
new GenericVulnerabilityResponseBean<>(
getResponseForURLConnection(u), true),
HttpStatus.OK);
URLConnection urlConnection = u.openConnection();
try (BufferedReader reader =
new BufferedReader(new InputStreamReader(urlConnection.getInputStream()))) {
return new ResponseEntity<>(
new GenericVulnerabilityResponseBean<>(
reader.lines().collect(Collectors.joining()), true),
HttpStatus.OK);
}
}
} else {
return invalidUrlResponse();
}
}

String getResponseForURLConnection(URL u) throws IOException {
URLConnection urlConnection = u.openConnection();
try (BufferedReader reader =
new BufferedReader(new InputStreamReader(urlConnection.getInputStream()))) {
return reader.lines().collect(Collectors.joining());
}
}

@AttackVector(
vulnerabilityExposed = VulnerabilityType.SIMPLE_SSRF,
description = "SSRF_VULNERABILITY_URL_WITHOUT_CHECK",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,13 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.spy;

import java.io.File;
import java.io.IOException;
import java.net.URL;
import java.nio.file.Files;
import java.util.Collections;
import java.util.stream.Stream;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.io.TempDir;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
Expand All @@ -41,18 +36,7 @@ class SSRFVulnerabilityTest {

private static String tempFileUrl;

private SSRFVulnerability ssrfVulnerability;

@BeforeEach
void each() throws IOException {
SSRFVulnerability ssrfSpy = spy(new SSRFVulnerability(GIST_ID));
// mocks network calls
doReturn(GIST_URL_CONTENT).when(ssrfSpy).getResponseForURLConnection(eq(new URL(GIST_URL)));
doReturn(OTHER_URL_CONTENT)
.when(ssrfSpy)
.getResponseForURLConnection(eq(new URL(OTHER_URL)));
ssrfVulnerability = ssrfSpy;
}
private final SSRFVulnerability ssrfVulnerability = new SSRFVulnerability(GIST_ID);

@BeforeAll
static void setUp() throws IOException {
Expand Down
Loading