Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote some unit tests for the JWT vulnerabilities (#398), testing the controller functions and some validator exploits to the best of my ability.
I refactored some relatively minor things to make the controller easier to test:
IJWTTokenGenerator
, so I can also use it in the test without too much duplicationJWTAlgorithmKMS
, manage it's singleton lifecycle via Spring instead, mainly so I can inject it into the controller and spy on it in the testString
type of the RequestEntity parameters withVoid
, this should be the correct type for GET-Requests and allows creation of test objects