Add e2e test case for flatpak #17207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
No-CherryPick
ekohl
reviewed
Dec 19, 2024
tests/foreman/cli/test_flatpak.py
Outdated
| remote_name = f'SAT-remote-{gen_string("alpha")}' | ||
| res = host.execute( | ||
| 'flatpak --user remote-add --authenticator-name=org.flatpak.Authenticator.Oci ' | ||
| f'{remote_name} oci+https://{sat.hostname}/pulpcore_registry/' |
There was a problem hiding this comment.
Is this the intended user flow or is this something that host registration should set up if it detects flatpak?
There was a problem hiding this comment.
There was a problem hiding this comment.
Global registration will need to install podman and flatpak on the client and then run the remote-add. For now, we will leave it to the admins to set it up..
vsedmik
force-pushed
the
add-flatpak-client
branch
from
e136e07 to
a96198f
Compare
|
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
ogajduse
reviewed
Jan 15, 2025
pytest_fixtures/core/contenthosts.py
Outdated
Comment on lines
244
to
246
| for pkg in ['podman', 'flatpak', 'dbus-x11']: | ||
| res = host.execute(f'dnf -y install {pkg}') | ||
| assert res.status == 0, f'{pkg} installation failed: {res.stderr}' |
There was a problem hiding this comment.
Can this be a single DNF transaction?
Suggested change
| for pkg in ['podman', 'flatpak', 'dbus-x11']: | |
| res = host.execute(f'dnf -y install {pkg}') | |
| assert res.status == 0, f'{pkg} installation failed: {res.stderr}' | |
| pkgs = ['podman', 'flatpak', 'dbus-x11'] | |
| res = host.execute(f'dnf -y install {' '.join(pkgs)}') | |
| assert res.status == 0, f'Package installation failed: {res.stderr}' |
There was a problem hiding this comment.
@ogajduse It could be. I just wanted to keep it separate to provide more info which installation failed and why through res.stderr. But it doesn't matter so much probably, dnf should return some meaningful info anyway.
Satellite-QE
removed
the
PRT-Passed
|
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
vijaysawant
approved these changes
Jan 15, 2025
synkd
approved these changes
Jan 15, 2025
damoore044
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
In Satellite 6.17 we are going to support full path for host setup and flatpak app installation on a content host, including REX templates to make it more user-friendly. We should have an E2E test case to cover all of that too.
Solution
This PR adds such a test case (and fixes two typos).
Related Issues
https://issues.redhat.com/browse/SAT-28557
https://issues.redhat.com/browse/SAT-4420
Requires
Katello/katello#11223 (in snap)
Katello/hammer-cli-katello#971 (in snap)
Katello/katello#11264
PRT test Cases example