Fix multiple services in gRPC extension #304 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuapassos
changed the title
Krzysztof-Cieslak
requested changes
Sep 27, 2021
| @@ -21,6 +21,6 @@ type Saturn.Application.ApplicationBuilder with | |||
| app.UseEndpoints (fun endpoints -> endpoints.MapGrpcService<'a>() |> ignore) | |||
|
|
|||
| { state with | |||
| AppConfigs = configureApp::configureGrpcEndpoint::state.AppConfigs | |||
| AppConfigs = configureApp::configureGrpcEndpoint::state.AppConfigs.[1.. state.AppConfigs.Length] | |||
There was a problem hiding this comment.
This sounds risky - as far as I understand it'd potentially break if the use_grpc calls were not in a row.
For example, if I had in my application following code it would remove the wrong entry in state.AppConfigs:
use_grpc MyHelloWithDI
use_static
use_grpc MyCalculatorWithDI
TBF, I'm not yet sure what's the good solution here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use
use_grpca lot of times, theconfigureAppis added more times in appConfig making multiples sercices dont work corretly.Now
configureAppis inserted only once.Fix #304