Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use aws-sdk for signing packages #5

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nguyentoanit
Copy link

No description provided.

@nguyentoanit nguyentoanit changed the title Refactor/ghorg 22 refactor aws4 axios to use aws sdk signing package refactor: use aws-sdk for signing packages Aug 16, 2021
@nguyentoanit
Copy link
Author

nguyentoanit commented Aug 16, 2021

Hey @moltar,
Unfortunately, we missed some integration tests. And this caused a number of issues.
Therefore, I reset our main branch and had some updated for them.

Please help me take a look them. Thanks. 🙇

@nguyentoanit nguyentoanit requested a review from moltar September 20, 2021 01:27
@nguyentoanit nguyentoanit force-pushed the refactor/GHORG-22-refactor-aws4-axios-to-use-aws-sdk-signing-package branch from e8a2768 to d738684 Compare September 20, 2021 02:21
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
67.0% 67.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants