feat: removes DefinitelyTyped types in favor of packaged types

[etler]

Polly sub packages were updated a few years ago to add type definition files into the main project:

Netflix/pollyjs@be036a1

Definitely typed packages are no longer needed and the conflict causes issues when using yarn.

Installing this package as a dependency in a different project with yarn produces these warnings:

warning @types/pollyjs__adapter-node-http > @types/[email protected]: This is a stub types definition. @pollyjs/adapter provides its own type definitions, so you do not need this installed.
warning @types/pollyjs__core > @types/[email protected]: This is a stub types definition. @pollyjs/adapter provides its own type definitions, so you do not need this installed.
warning @types/pollyjs__core > @types/[email protected]: This is a stub types definition. @pollyjs/persister provides its own type definitions, so you do not need this installed.
warning @types/pollyjs__persister-fs > @types/[email protected]: This is a stub types definition. @pollyjs/persister provides its own type definitions, so you do not need this installed.

When trying to build a typescript project using yarn tsc that uses this package as a dependency it causes this typescript error:

$ tsc --build tsconfig.build.json
error TS2688: Cannot find type definition file for 'pollyjs__adapter'.
  The file is in the program because:
    Entry point for implicit type library 'pollyjs__adapter'

error TS2688: Cannot find type definition file for 'pollyjs__persister'.
  The file is in the program because:
    Entry point for implicit type library 'pollyjs__persister'


Found 2 errors.

error Command failed with exit code 1.

These errors don't appear to be an issue with npm, but is a major issue for any consumers using yarn.

I also moved @types/setup-polly-jest into dev dependencies since it types are not needed for runtime installs.

[moltar]

Thank you for spotting this and thank you for your contribution @etler!

[github-actions]

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀