Skip to content

Commit

Permalink
fix(one-off): remove async one-off
Browse files Browse the repository at this point in the history
  • Loading branch information
SCedricThomas committed Apr 26, 2024
1 parent fc79e63 commit 8c68b28
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 11 deletions.
5 changes: 0 additions & 5 deletions apps/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ type RunOpts struct {
DisplayCmd string
Silent bool
Detached bool
Async bool
Size string
Type string
Cmd []string
Expand Down Expand Up @@ -105,9 +104,6 @@ func Run(ctx context.Context, opts RunOpts) error {
if opts.StdoutCopyFunc != nil {
runCtx.stdoutCopyFunc = opts.StdoutCopyFunc
}
if opts.Detached {
opts.Async = false
}

env, err := runCtx.buildEnv(opts.CmdEnv)
if err != nil {
Expand All @@ -127,7 +123,6 @@ func Run(ctx context.Context, opts RunOpts) error {
Env: env,
Size: opts.Size,
Detached: opts.Detached,
Async: opts.Async,
},
)
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion cmd/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ var (
Files: c.StringSlice("f"),
Silent: c.Bool("silent"),
Detached: c.Bool("detached"),
Async: true,
}
if (c.Args().Len() == 0 && c.String("t") == "") || (c.Args().Len() > 0 && c.String("t") != "") {
cli.ShowCommandHelp(c, "run")
Expand Down
1 change: 0 additions & 1 deletion db/influxdb_console.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ func InfluxDBConsole(ctx context.Context, opts InfluxDBConsoleOpts) error {
App: opts.App,
Cmd: cmd,
Size: opts.Size,
Async: true,
}

err = apps.Run(ctx, runOpts)
Expand Down
1 change: 0 additions & 1 deletion db/mongo_console.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ func MongoConsole(ctx context.Context, opts MongoConsoleOpts) error {
App: opts.App,
Cmd: append(command, "'"+mongoURL.String()+"'"),
Size: opts.Size,
Async: true,
})
if err != nil {
return errgo.Newf("fail to run MongoDB console: %v", err)
Expand Down
1 change: 0 additions & 1 deletion db/mysql_console.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ func MySQLConsole(ctx context.Context, opts MySQLConsoleOpts) error {
App: opts.App,
Cmd: []string{"dbclient-fetcher", "mysql", "&&", "mysql", "-h", host, "-P", port, fmt.Sprintf("--password=%v", password), "-u", user, user},
Size: opts.Size,
Async: true,
}

err = apps.Run(ctx, runOpts)
Expand Down
1 change: 0 additions & 1 deletion db/pgsql_console.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ func PgSQLConsole(ctx context.Context, opts PgSQLConsoleOpts) error {
App: opts.App,
Cmd: []string{"dbclient-fetcher", "pgsql", "&&", "psql", "'" + postgreSQLURL.String() + "'"},
Size: opts.Size,
Async: true,
}

err = apps.Run(ctx, runOpts)
Expand Down
1 change: 0 additions & 1 deletion db/redis_console.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func RedisConsole(ctx context.Context, opts RedisConsoleOpts) error {
App: opts.App,
Cmd: []string{"dbclient-fetcher", "redis", "&&", "redis-cli", "-h", host, "-p", port, "-a", password},
Size: opts.Size,
Async: true,
StdinCopyFunc: redisStdinCopy,
}

Expand Down

0 comments on commit 8c68b28

Please sign in to comment.