fix(actions): test conditional needs #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
curzolapierre
commented
Mar 14, 2024
curzolapierre
commented
- Add a changelog entry in the section "To Be Released" of CHANGELOG.md
curzolapierre
force-pushed
the
fix/release_action
branch
from
01d603c to
b6fd3cd
Compare
EtienneM
reviewed
Mar 14, 2024
.github/workflows/publish.yml
Outdated
| if: startsWith(github.ref, 'refs/tags/') | ||
| # related to https://github.com/actions/runner/issues/2205 | ||
| # since a success() is added by default and skipped jobs make success to fail we need this workaround | ||
| if: ${{ always() && startsWith(github.ref, 'refs/tags/') && (needs.linter-master.result == 'success' || needs.linter-pull-request.result =='success') }} |
There was a problem hiding this comment.
question: do we really need the surrounding ${{ .. }}? From actions/runner#2205 (comment) it does not seem so
nitpick: you lack a space in both if
Suggested change
| if: ${{ always() && startsWith(github.ref, 'refs/tags/') && (needs.linter-master.result == 'success' || needs.linter-pull-request.result =='success') }} | |
| if: ${{ always() && startsWith(github.ref, 'refs/tags/') && (needs.linter-master.result == 'success' || needs.linter-pull-request.result == 'success') }} |
There was a problem hiding this comment.
The ${{ .. }} is needed in case of Yaml reserved character but indeed here it's not the case.
Comment on lines
+75
to
+80
| # related to https://github.com/actions/runner/issues/2205 | ||
| # since a success() is added by default and skipped jobs make success to fail we need this workaround |
There was a problem hiding this comment.
suggestion: you explain what the workaround is, but not what the problem is. Hence it's kind of complicated to understand the problem in the first place. Could you explain it?
There was a problem hiding this comment.
praise: thanks, nice explanation!
curzolapierre
force-pushed
the
fix/release_action
branch
from
b6fd3cd to
2cd76af
Compare
curzolapierre
force-pushed
the
fix/release_action
branch
from
2cd76af to
0305868
Compare
EtienneM
approved these changes
Mar 14, 2024
Comment on lines
+75
to
+80
| # related to https://github.com/actions/runner/issues/2205 | ||
| # since a success() is added by default and skipped jobs make success to fail we need this workaround |
There was a problem hiding this comment.
praise: thanks, nice explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.