Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORY-443] Add flag --no-letsencrypt when creating a domain #1058

Merged
merged 9 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

### To be Released

* fix(cmd): addons-info working for non-db addons ([PR#1055](https://github.com/Scalingo/cli/pull/1055))
* feat(domains): `domains-add` now supports `--no-letsencrypt` flag to completely disable Let's Encrypt certificat generation ([PR#1058](https://github.com/Scalingo/cli/pull/1058))
* fix(cmd): `addons-info` working for non-db addons ([PR#1055](https://github.com/Scalingo/cli/pull/1055))

### 1.31.0

Expand Down
2 changes: 1 addition & 1 deletion addons/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
2 changes: 1 addition & 1 deletion addons/destroy.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Destroy(ctx context.Context, app, addonID string) error {
Expand Down
2 changes: 1 addition & 1 deletion addons/info.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/db"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

// Info is the command handler displaying static information about one given addon
Expand Down
2 changes: 1 addition & 1 deletion addons/provision.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Provision(ctx context.Context, app, addon, plan string) error {
Expand Down
2 changes: 1 addition & 1 deletion addons/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Upgrade(ctx context.Context, app, addonID, plan string) error {
Expand Down
2 changes: 1 addition & 1 deletion alerts/add.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
2 changes: 1 addition & 1 deletion alerts/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
2 changes: 1 addition & 1 deletion apps/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Create(ctx context.Context, appName string, remote string, buildpack string) error {
Expand Down
2 changes: 1 addition & 1 deletion apps/events.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/events"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Events(ctx context.Context, app string, paginationOpts scalingo.PaginationOpts) error {
Expand Down
4 changes: 2 additions & 2 deletions apps/info.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import (
"github.com/olekukonko/tablewriter"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
"github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
4 changes: 2 additions & 2 deletions apps/logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/logs"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type WSEvent struct {
Expand Down
2 changes: 1 addition & 1 deletion apps/one_off_stop.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func OneOffStop(ctx context.Context, appName, oneOffLabel string) error {
Expand Down
2 changes: 1 addition & 1 deletion apps/operations.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
errors "github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
2 changes: 1 addition & 1 deletion apps/restart.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Restart(ctx context.Context, app string, sync bool, args []string) error {
Expand Down
4 changes: 2 additions & 2 deletions apps/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ import (
"github.com/Scalingo/cli/io"
"github.com/Scalingo/cli/signals"
"github.com/Scalingo/cli/term"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
errors "github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
4 changes: 2 additions & 2 deletions apps/run/run_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/httpclient"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type UpdateTtyParams struct {
Expand Down
2 changes: 1 addition & 1 deletion apps/run/run_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"net"
"os"

scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func NotifiedSignals() chan os.Signal {
Expand Down
6 changes: 3 additions & 3 deletions apps/scale.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v6/http"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
"github.com/Scalingo/go-scalingo/v7/http"
"github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
2 changes: 1 addition & 1 deletion apps/sendsignal.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
2 changes: 1 addition & 1 deletion apps/stats.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion autoscalers/add.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

func Add(ctx context.Context, app string, params scalingo.AutoscalerAddParams) error {
Expand Down
2 changes: 1 addition & 1 deletion autoscalers/get_from_container_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

"gopkg.in/errgo.v1"

"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion autoscalers/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/io"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-utils/errors/v2"
)

Expand Down
2 changes: 1 addition & 1 deletion cmd/alerts.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/Scalingo/cli/cmd/autocomplete"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions cmd/autocomplete/apps.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type appsCache struct {
Expand Down
4 changes: 2 additions & 2 deletions cmd/autocomplete/collaborators_add.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import (
"gopkg.in/errgo.v1"

"github.com/Scalingo/cli/config"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

func CollaboratorsAddAutoComplete(c *cli.Context) error {
Expand Down
2 changes: 1 addition & 1 deletion cmd/autocomplete/current_app.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7/debug"
)

func CurrentAppCompletion(c *cli.Context) string {
Expand Down
2 changes: 1 addition & 1 deletion cmd/autocomplete/flag_app.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (

"github.com/urfave/cli/v2"

"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7/debug"
)

func FlagAppAutoComplete(c *cli.Context) bool {
Expand Down
2 changes: 1 addition & 1 deletion cmd/autoscalers.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"github.com/Scalingo/cli/cmd/autocomplete"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions cmd/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import (
"github.com/Scalingo/cli/config"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/session"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/debug"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/debug"
)

type AppCommands struct {
Expand Down
2 changes: 1 addition & 1 deletion cmd/databases.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
dbUsers "github.com/Scalingo/cli/db/users"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
"github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v7"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions cmd/deployments.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"github.com/Scalingo/cli/deployments"
"github.com/Scalingo/cli/detect"
"github.com/Scalingo/cli/utils"
scalingo "github.com/Scalingo/go-scalingo/v6"
"github.com/Scalingo/go-scalingo/v6/io"
"github.com/Scalingo/go-scalingo/v7"
"github.com/Scalingo/go-scalingo/v7/io"
)

var (
Expand Down
Loading