-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STORY-642] new api endpoint to handle password reset #1071
Merged
sc-zenokerr
merged 5 commits into
master
from
fix/story-642/new-api-endpoint-to-handle-password-reset
Jul 8, 2024
+74
−45
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
db2e8ec
Database user password update uses new API endpoint for generating pa…
sc-zenokerr 99a1b68
Update CHANGELOG.md
sc-zenokerr 3b349b4
Update function call to DatabaseUserResetPassword
sc-zenokerr a62356f
Alter console output of UpdateUserPassword
sc-zenokerr 90cbf3a
Update dependency go-scalingo v7.0.1
sc-zenokerr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Database user password update uses new API endpoint for generating pa…
…ssword. This is dependent on the merging / release of the equivalent branch in go-scalingo library.
commit db2e8ecd5d56e3b8b19121caf987a528b02f2456
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I like returning the function as soon as possible. In this case, you could return here and the
else
is useless. There is less indentation which makes the code easier to read IMOThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I actually misread the original flow. Your suggestion is absolutely correct. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. My question was answered by benjamin in the comments in the [STORY-642] in notion.
It should be (remain) possible to set a user-supplied password using the CLI.