Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: filter for all one-off #798

Closed
wants to merge 1 commit into from
Closed

WIP: filter for all one-off #798

wants to merge 1 commit into from

Conversation

btrd
Copy link
Contributor

@btrd btrd commented Sep 27, 2022

fix #799

@btrd btrd marked this pull request as draft September 27, 2022 09:22
@btrd btrd requested a review from EtienneM September 27, 2022 09:24
@btrd
Copy link
Contributor Author

btrd commented Sep 27, 2022

From my local test, it doesn't work :(
Maybe the log-service doesn't allow this filter ?

@EtienneM EtienneM requested review from SCedricThomas and removed request for SCedricThomas September 27, 2022 13:50
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently our backend does not support this syntax. Is there a reason that the customer don't use grep? I mean, it should be possible to do:

scalingo --app my-app logs | grep one-off

WDYT?

@btrd
Copy link
Contributor Author

btrd commented Sep 27, 2022

  • to prevent from having to download every log lines
  • grep doesn't work when using -f
  • if web & web-1 if valid, there is no reason (from the point of view of the client) that one-off-1 work but not one-off

I think we can close this PR, I let you decide what to do with the issue.

@btrd
Copy link
Contributor Author

btrd commented Sep 27, 2022

Need a change in https://github.com/Scalingo/logs-service to work.

@btrd btrd closed this Sep 27, 2022
@EtienneM EtienneM deleted the feat/improve_filter branch September 27, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[logs] --filter should accept the one-off router
2 participants