Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(composer): match exactly the extension name #440

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(composer): match exactly the extension name #440

merged 1 commit into from
Jun 18, 2024

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Jun 18, 2024 •
edited
Loading

Fix #441

Tested on a test app: https://biniou.osc-fr1.scalingo.io/#module_pdo_sqlsrv

image

Deployment logs excerpt:

[...]
-----> Bundling additional extensions
Installing PECL extension pdo_sqlsrv version 5.12.0
Installing PECL extension sqlsrv version 5.12.0
-----> Installing application dependencies with Composer
[...]

@EtienneM EtienneM self-assigned this Jun 18, 2024
@EtienneM EtienneM marked this pull request as ready for review June 18, 2024 14:31
@EtienneM EtienneM requested a review from Frzk June 18, 2024 14:31
@EtienneM EtienneM enabled auto-merge June 18, 2024 14:31
Frzk
Frzk approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Frzk Frzk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@EtienneM EtienneM merged commit dd6ef6d into master Jun 18, 2024
2 checks passed
@EtienneM EtienneM deleted the fix/sqlsrv_extension branch June 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frzk Frzk Frzk approved these changes

Assignees

@EtienneM EtienneM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_embedded_extension check must match the exact extension name
2 participants
@EtienneM @Frzk