Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nodejs): update Node.js spelling in logs #450

Merged
merged 1 commit into from
Jul 24, 2024
Merged

docs(nodejs): update Node.js spelling in logs #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/nodejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function install_node_deps() {
return 0
fi

status "NODE (package.json) app detected"
status "Node.js app detected (package.json)"

compile_node $BUILD_DIR $CACHE_DIR

Expand All @@ -17,7 +17,7 @@ function install_node_deps() {
ln -s ${BUILD_DIR}/${node_path}/ /app/${node_path}
ln -s ${BUILD_DIR}/node_modules /app/node_modules

echo "Node " `node -v` | indent
echo "Node.js " $(node --version) | indent
}

function compile_node() {
Expand Down Expand Up @@ -53,12 +53,12 @@ function compile_node() {
if [ "$semver_range" == "" ]; then
status "Defaulting to latest stable node: $node_version"
else
status "Requested node range: $semver_range"
status "Resolved node version: $node_version"
status "Requested Node.js versions range: $semver_range"
status "Resolved Node.js version: $node_version"
fi

# Download node from Heroku's S3 mirror of nodejs.org/dist
status "Downloading and installing node"
status "Downloading and installing Node.js"
node_url="https://heroku-nodebin.s3.us-east-1.amazonaws.com/node/release/linux-x64/node-v${node_version}-linux-x64.tar.gz"
curl $node_url --location -s -o - | tar xzf - -C $build_dir

Expand Down Expand Up @@ -90,10 +90,10 @@ function compile_node() {
test -d $cache_dir/node_modules && cp -r $cache_dir/node_modules $build_dir/
fi

status "Installing dependencies"
status "Installing Node.js dependencies"
npm install --production 2>&1 | indent

status "Pruning unused dependencies"
status "Pruning unused Node.js dependencies"
npm prune 2>&1 | indent

status "Caching node_modules for future builds"
Expand Down